feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Squish: Use sets instead of lists for kits in use

Browse Source 
They fit our use-case much better.

Task-number: QTCREATORBUG-20874
Change-Id: Ifa06ce00f3e6999a99c3bc2bb7e9ba759fa02e94
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Robert Loehning
2018-08-02 20:50:03 +02:00
parent 6564922254
commit 21bcc7f38b
4 changed files with 31 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/system/shared/classes.py
View File

@@ -44,7 +44,7 @@ class Targets:
@staticmethod
def availableTargetClasses():
availableTargets = list(Targets.ALL_TARGETS)
availableTargets = set(Targets.ALL_TARGETS)
if platform.system() in ('Windows', 'Microsoft'):
availableTargets.remove(Targets.EMBEDDED_LINUX)
elif platform.system() == 'Darwin':
@@ -54,8 +54,7 @@ class Targets:
@staticmethod
def desktopTargetClasses():
desktopTargets = Targets.availableTargetClasses()
if Targets.EMBEDDED_LINUX in desktopTargets:
desktopTargets.remove(Targets.EMBEDDED_LINUX)
desktopTargets.discard(Targets.EMBEDDED_LINUX)
return desktopTargets
@staticmethod
@@ -64,10 +63,7 @@ class Targets:
@staticmethod
def getTargetsAsStrings(targets):
if not isinstance(targets, (tuple,list)):
test.fatal("Wrong usage... This function handles only tuples or lists.")
return None
return map(Targets.getStringForTarget, targets)
return set(map(Targets.getStringForTarget, targets))
@staticmethod
def getIdForTargetName(targetName):