From 21c97400896fe48fcfb9f3e81e3ab70a5e604cf4 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Thu, 7 Jun 2018 14:41:34 +0300 Subject: [PATCH] Qmake: Expand user arguments when comparing them to the Makefile If the user used a macro, the Makefile will never match it, and qmake will be executed on each build. Change-Id: I2790db3a788ea7971145b475781a6193a1ed0842 Reviewed-by: Oswald Buddenhagen Reviewed-by: Tobias Hunger --- src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp b/src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp index b079ef27dcf..3fe051f7784 100644 --- a/src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp +++ b/src/plugins/qmakeprojectmanager/qmakebuildconfiguration.cpp @@ -387,7 +387,7 @@ QmakeBuildConfiguration::MakefileState QmakeBuildConfiguration::compareToImportF // and compare that on its own QString workingDirectory = QFileInfo(makefile).absolutePath(); QStringList actualArgs; - QString userArgs = qs->userArguments(); + QString userArgs = macroExpander()->expandProcessArgs(qs->userArguments()); // This copies the settings from userArgs to actualArgs (minus some we // are not interested in), splitting them up into individual strings: extractSpecFromArguments(&userArgs, workingDirectory, version, &actualArgs);