feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Apply new SettingsPage patterns

Browse Source 
Change-Id: I7b2c7cf06ed79926fbbd00d4df479c0e0a7da249
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-01-16 17:51:53 +01:00
parent 952c7fcfd7
commit 21f6445781
4 changed files with 60 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/plugins/valgrind/valgrindplugin.cpp
View File

@@ -53,40 +53,6 @@ using namespace ProjectExplorer;
namespace Valgrind {
namespace Internal {
class ValgrindOptionsPage : public IOptionsPage
{
public:
explicit ValgrindOptionsPage(QObject *parent)
: IOptionsPage(parent)
{
setId(ANALYZER_VALGRIND_SETTINGS);
setDisplayName(QCoreApplication::translate("Valgrind::Internal::ValgrindOptionsPage", "Valgrind"));
setCategory("T.Analyzer");
setDisplayCategory(QCoreApplication::translate("Analyzer", "Analyzer"));
setCategoryIconPath(Analyzer::Icons::SETTINGSCATEGORY_ANALYZER);
}
QWidget *widget() override
{
if (!m_widget)
m_widget = new ValgrindConfigWidget(ValgrindGlobalSettings::instance(), true);
return m_widget;
}
void apply() override
{
ValgrindGlobalSettings::instance()->writeSettings();
}
void finish() override
{
delete m_widget;
}
private:
QPointer<QWidget> m_widget;
};
class ValgrindRunConfigurationAspect : public GlobalOrProjectAspect
{
public:
@@ -109,6 +75,7 @@ public:
ValgrindGlobalSettings valgrindGlobalSettings; // Needs to come before the tools.
MemcheckTool memcheckTool;
CallgrindTool callgrindTool;
ValgrindOptionsPage valgrindOptionsPage;
};
ValgrindPlugin::~ValgrindPlugin()
@@ -120,8 +87,6 @@ bool ValgrindPlugin::initialize(const QStringList &, QString *)
{
d = new ValgrindPluginPrivate;
new ValgrindOptionsPage(this);
RunConfiguration::registerAspect<ValgrindRunConfigurationAspect>();
return true;