feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Add PropertyNameLiteral

Browse Source 
That hopefully makes it really hard to create a literal from dynamic or
automatic memory. Only global string literals should be used.

In header you should use:
MakeHeaderPropertyViewLiteral(foo, "Foo");
Makes foo constexpr and provides internal linkage.

In cpp files you should use:
MakeHeaderPropertyViewLiteral(foo, "Foo");
Makes foo constexpr and provides external linkage.

In a function scope you should use:
MakeCppPropertyViewLiteral(foo, "Foo");
Makes foo constexpr but does not add it to the stack.
All three provide a const QString& on demand. So no code is executed as
the program is started.

Change-Id: I924efbb1f5c2b2c811f3eeae042ff2eec8de3faf
Reviewed-by: Aleksei German <aleksei.german@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This commit is contained in:
Marco Bubke
2023-09-07 11:39:41 +02:00
parent 72a45dc2fb
commit 22009b6967
1 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/plugins/qmldesigner/designercore/include/modelfwd.h
View File

@@ -7,11 +7,46 @@
#include "qmldesignercorelib_exports.h" #include "qmldesignercorelib_exports.h"
#include <utils/smallstringview.h> #include <utils/smallstringview.h>
#include <utils/span.h>
namespace QmlDesigner { namespace QmlDesigner {
using PropertyName = QByteArray; using PropertyName = QByteArray;
using PropertyNameView = QByteArrayView; using PropertyNameView = QByteArrayView;
using PropertyNameList = QList<PropertyName>; using PropertyNameList = QList<PropertyName>;
template<std::size_t Size, const char Text[Size]>
class ByteArrayViewLiteral : public QByteArrayView
{
public:
constexpr ByteArrayViewLiteral() noexcept
: QByteArrayView{Text, Size - 1}
{}
const QByteArray &toByteArray() const noexcept
{
static auto b = QByteArray::fromRawData(Text, Size - 1);
return b;
}
operator const QByteArray &() const noexcept { return toByteArray(); }
};
#define MakeCppPropertyViewLiteral(name, text) \
constexpr char name##InternalString[] = text; \
constexpr ByteArrayViewLiteral<sizeof(name##InternalString), name##InternalString> name{}; \
/* */
#define MakeHeaderPropertyViewLiteral(name, text) \
inline constexpr char name##InternalString[] = text; \
inline constexpr ByteArrayViewLiteral<sizeof(name##InternalString), name##InternalString> name{}; \
/* */
#define MakeFunctionPropertyViewLiteral(name, text) \
static constexpr char name##InternalString[] = text; \
static constexpr ByteArrayViewLiteral<sizeof(name##InternalString), name##InternalString> name{}; \
/* */
using TypeName = QByteArray; using TypeName = QByteArray;
using PropertyTypeList = QList<PropertyName>; using PropertyTypeList = QList<PropertyName>;
using IdName = QByteArray; using IdName = QByteArray;