From 220882128a0d1d8945f10d6ce959d3eab358715c Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Sat, 7 Mar 2015 20:22:32 +0200 Subject: [PATCH] Utils: Fix parentheses parsing in arguments iteration Opening parenthesis is stored in the value, but closing parenthesis is not. This makes the value unbalanced. Since the parenthesis unconditionally unset m_simple, the value is cleared anyway and is never read. In case that math (or other) expression will ever be evaluated, this needs to be reworked to include both parentheses. Change-Id: Ie56f5a5d9cec5a47649751db4245888bee8e85d8 Reviewed-by: Oswald Buddenhagen --- src/libs/utils/qtcprocess.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/utils/qtcprocess.cpp b/src/libs/utils/qtcprocess.cpp index 0750d4a7396..2960028f936 100644 --- a/src/libs/utils/qtcprocess.cpp +++ b/src/libs/utils/qtcprocess.cpp @@ -1436,6 +1436,7 @@ bool QtcProcess::ArgIterator::next() state.current = MxParen; m_simple = false; hadWord = true; + continue; #if 0 // Should match only at the beginning of a command, which we never have currently. } else if (cc == '{') { sstack.push(state);