BaseAnnotationHighlighter: Get rid of QTextDocument arg from c'tor

It's always nullptr.

Change-Id: Ia392b826f0afe8562b90b916722c374c5244d9aa
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

src/plugins/bazaar/annotationhighlighter.cpp

@@ -6,9 +6,8 @@
 
 namespace Bazaar::Internal {
 
-BazaarAnnotationHighlighter::BazaarAnnotationHighlighter(const VcsBase::Annotation &annotation,
+BazaarAnnotationHighlighter::BazaarAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                                         QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
     , m_changeset(QLatin1String(Constants::ANNOTATE_CHANGESET_ID))
 {}
 

src/plugins/bazaar/annotationhighlighter.h

@@ -10,8 +10,7 @@ namespace Bazaar::Internal {
 class BazaarAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
 public:
-    explicit BazaarAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit BazaarAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                         QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const override;

src/plugins/clearcase/annotationhighlighter.cpp

@@ -5,9 +5,8 @@
 
 namespace ClearCase::Internal {
 
-ClearCaseAnnotationHighlighter::ClearCaseAnnotationHighlighter(const VcsBase::Annotation &annotation,
+ClearCaseAnnotationHighlighter::ClearCaseAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                                               QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
 {}
 
 QString ClearCaseAnnotationHighlighter::changeNumber(const QString &block) const

src/plugins/clearcase/annotationhighlighter.h

@@ -12,8 +12,7 @@ class ClearCaseAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
     Q_OBJECT
 public:
-    explicit ClearCaseAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit ClearCaseAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                            QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const override;

src/plugins/cvs/cvseditor.cpp

@@ -25,9 +25,8 @@ namespace Cvs::Internal {
 class CvsAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
 public:
-    explicit CvsAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit CvsAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                      QTextDocument *document = nullptr)
+        : VcsBase::BaseAnnotationHighlighter(annotation)
-        : VcsBase::BaseAnnotationHighlighter(annotation, document)
     {}
 
 private:

src/plugins/fossil/annotationhighlighter.cpp

@@ -9,9 +9,8 @@
 namespace Fossil {
 namespace Internal {
 
-FossilAnnotationHighlighter::FossilAnnotationHighlighter(const VcsBase::Annotation &annotation,
+FossilAnnotationHighlighter::FossilAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                                         QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
     , m_changesetIdPattern(Constants::CHANGESET_ID)
 {
     QTC_CHECK(m_changesetIdPattern.isValid());

src/plugins/fossil/annotationhighlighter.h

@@ -11,8 +11,7 @@ namespace Internal {
 class FossilAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
 public:
-    explicit FossilAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit FossilAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                         QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const final;

src/plugins/git/annotationhighlighter.cpp

@@ -6,9 +6,8 @@
 namespace Git {
 namespace Internal {
 
-GitAnnotationHighlighter::GitAnnotationHighlighter(const VcsBase::Annotation &annotation,
+GitAnnotationHighlighter::GitAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                                   QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
 {}
 
 QString GitAnnotationHighlighter::changeNumber(const QString &block) const

src/plugins/git/annotationhighlighter.h

@@ -13,8 +13,7 @@ class GitAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
     Q_OBJECT
 public:
-    explicit GitAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit GitAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                      QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const override;

src/plugins/mercurial/annotationhighlighter.cpp

@@ -6,9 +6,8 @@
 
 namespace Mercurial::Internal {
 
-MercurialAnnotationHighlighter::MercurialAnnotationHighlighter(const VcsBase::Annotation &annotation,
+MercurialAnnotationHighlighter::MercurialAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                                               QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
     , changeset(QLatin1String(Constants::CHANGESETID12))
 {
 }

src/plugins/mercurial/annotationhighlighter.h

@@ -10,8 +10,7 @@ namespace Mercurial::Internal {
 class MercurialAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
 public:
-    explicit MercurialAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit MercurialAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                            QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const override;

src/plugins/perforce/annotationhighlighter.cpp

@@ -5,9 +5,8 @@
 
 namespace Perforce::Internal {
 
-PerforceAnnotationHighlighter::PerforceAnnotationHighlighter(const VcsBase::Annotation &annotation,
+PerforceAnnotationHighlighter::PerforceAnnotationHighlighter(const VcsBase::Annotation &annotation)
-                                                             QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
 { }
 
 QString PerforceAnnotationHighlighter::changeNumber(const QString &block) const

src/plugins/perforce/annotationhighlighter.h

@@ -12,8 +12,7 @@ class PerforceAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighter
 {
     Q_OBJECT
 public:
-    explicit PerforceAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit PerforceAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                           QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const override;

src/plugins/subversion/annotationhighlighter.cpp

@@ -6,9 +6,8 @@
 using namespace Subversion;
 using namespace Subversion::Internal;
 
-SubversionAnnotationHighlighter::SubversionAnnotationHighlighter(
+SubversionAnnotationHighlighter::SubversionAnnotationHighlighter(const VcsBase::Annotation &annotation)
-    const VcsBase::Annotation &annotation, QTextDocument *document)
+    : VcsBase::BaseAnnotationHighlighter(annotation)
-    : VcsBase::BaseAnnotationHighlighter(annotation, document)
     , m_blank(QLatin1Char(' '))
 {}
 

src/plugins/subversion/annotationhighlighter.h

@@ -13,8 +13,7 @@ class SubversionAnnotationHighlighter : public VcsBase::BaseAnnotationHighlighte
 {
     Q_OBJECT
 public:
-    explicit SubversionAnnotationHighlighter(const VcsBase::Annotation &annotation,
+    explicit SubversionAnnotationHighlighter(const VcsBase::Annotation &annotation);
-                                             QTextDocument *document = nullptr);
 
 private:
     QString changeNumber(const QString &block) const override;

src/plugins/vcsbase/baseannotationhighlighter.cpp

@@ -78,9 +78,8 @@ QSet<QString> BaseAnnotationHighlighterPrivate::annotationChanges() const
     return changes;
 }
 
-
+BaseAnnotationHighlighter::BaseAnnotationHighlighter(const Annotation &annotation)
-BaseAnnotationHighlighter::BaseAnnotationHighlighter(const Annotation &annotation, QTextDocument *document)
+    : TextEditor::SyntaxHighlighter()
-    : TextEditor::SyntaxHighlighter(document)
     , d(new BaseAnnotationHighlighterPrivate(this))
 {
     setDefaultTextFormatCategories();

src/plugins/vcsbase/baseannotationhighlighter.h

@@ -26,8 +26,7 @@ class VCSBASE_EXPORT BaseAnnotationHighlighter : public TextEditor::SyntaxHighli
 public:
     typedef  QSet<QString> ChangeNumbers;
 
-    explicit BaseAnnotationHighlighter(const Annotation &annotation,
+    explicit BaseAnnotationHighlighter(const Annotation &annotation);
-                                       QTextDocument *document = nullptr);
     ~BaseAnnotationHighlighter() override;