feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Remove one use of AnalyzerStartParameters::useStartupProject

Browse Source 
That information is now passed directly to the RunControl after
its construction (and is still wrongly used afterwards to
distinguish local from remote runs)

Change-Id: Ifa21eea9f33b2602912cd3b1b2e884da4f53c0d9
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>
This commit is contained in:
hjk
2015-06-19 12:06:55 +02:00
parent efad927fc3
commit 224acfb0aa
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/valgrind/valgrindruncontrolfactory.cpp
View File

@@ -97,7 +97,6 @@ RunControl *ValgrindRunControlFactory::create(RunConfiguration *runConfiguration
sp.localRunMode = static_cast<ApplicationLauncher::Mode>(rc1->runMode()); sp.localRunMode = static_cast<ApplicationLauncher::Mode>(rc1->runMode());
} else if (RemoteLinux::AbstractRemoteLinuxRunConfiguration *rc2 = } else if (RemoteLinux::AbstractRemoteLinuxRunConfiguration *rc2 =
qobject_cast<RemoteLinux::AbstractRemoteLinuxRunConfiguration *>(runConfiguration)) { qobject_cast<RemoteLinux::AbstractRemoteLinuxRunConfiguration *>(runConfiguration)) {
sp.useStartupProject = false; // FIXME: This is wrong.
sp.debuggee = rc2->remoteExecutableFilePath(); sp.debuggee = rc2->remoteExecutableFilePath();
sp.connParams = DeviceKitInformation::device(rc2->target()->kit())->sshParameters(); sp.connParams = DeviceKitInformation::device(rc2->target()->kit())->sshParameters();
sp.debuggeeArgs = rc2->arguments().join(QLatin1Char(' ')); sp.debuggeeArgs = rc2->arguments().join(QLatin1Char(' '));