feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

GitPlugin: Simplify return statements

Browse Source 
Change-Id: If09c93acade749326b95bb1c6068b2d43a4d8551
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2023-08-02 11:37:20 +02:00
parent 8d8e60436d
commit 224e4eeb59
12 changed files with 40 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/git/giteditor.cpp
View File

@@ -110,11 +110,11 @@ QString GitEditorWidget::changeUnderCursor(const QTextCursor &c) const
// Any number is regarded as change number.
cursor.select(QTextCursor::WordUnderCursor);
if (!cursor.hasSelection())
return QString();
return {};
const QString change = cursor.selectedText();
if (m_changeNumberPattern.match(change).hasMatch())
return change;
return QString();
return {};
}
BaseAnnotationHighlighter *GitEditorWidget::createAnnotationHighlighter(const QSet<QString> &changes) const
@@ -317,7 +317,7 @@ QString GitEditorWidget::revisionSubject(const QTextBlock &inBlock) const
return block.text().trimmed();
}
}
return QString();
return {};
}
bool GitEditorWidget::supportChangeLinks() const
@@ -363,21 +363,21 @@ QWidget *GitEditorWidget::addFilterWidget()
QString GitEditorWidget::grepValue() const
{
if (!m_logFilterWidget)
return QString();
return {};
return m_logFilterWidget->grepLineEdit->text();
}
QString GitEditorWidget::pickaxeValue() const
{
if (!m_logFilterWidget)
return QString();
return {};
return m_logFilterWidget->pickaxeLineEdit->text();
}
QString GitEditorWidget::authorValue() const
{
if (!m_logFilterWidget)
return QString();
return {};
return m_logFilterWidget->authorLineEdit->text();
}