feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix Krazy warnings about values or keys iteration in QML code.

Browse Source 
Change-Id: I78be5ec702d06ecc155842e9f092a13fc1cd6197
Reviewed-by: Aurindam Jana <aurindam.jana@digia.com>
Reviewed-by: Christiaan Janssen <christiaan.janssen@digia.com>
This commit is contained in:
Friedemann Kleint
2013-03-14 14:12:52 +01:00
parent efe98de840
commit 225c21a0f2
5 changed files with 64 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/plugins/debugger/qml/qmlv8debuggerclient.cpp
View File

@@ -1390,13 +1390,7 @@ void QmlV8DebuggerClient::messageReceived(const QByteArray &data)
BreakHandler *handler = d->engine->breakHandler();
foreach (int v8Id, v8BreakpointIds) {
BreakpointModelId internalId;
foreach (const BreakpointModelId &id, d->breakpoints.keys()) {
if (d->breakpoints.value(id) == v8Id) {
internalId = id;
break;
}
}
const BreakpointModelId internalId = d->breakpoints.key(v8Id);
if (internalId.isValid()) {
const BreakpointParameters &params = handler->breakpointData(internalId);
@@ -1426,19 +1420,18 @@ void QmlV8DebuggerClient::messageReceived(const QByteArray &data)
//Update breakpoint data
BreakHandler *handler = d->engine->breakHandler();
foreach (int v8Id, v8BreakpointIds) {
foreach (const BreakpointModelId &id, d->breakpoints.keys()) {
if (d->breakpoints.value(id) == v8Id) {
BreakpointResponse br = handler->response(id);
if (br.functionName.isEmpty()) {
br.functionName = invocationText;
handler->setResponse(id, br);
}
if (handler->state(id) != BreakpointInserted) {
br.lineNumber = breakData.value(
_("sourceLine")).toInt() + 1;
handler->setResponse(id, br);
handler->notifyBreakpointInsertOk(id);
}
const BreakpointModelId id = d->breakpoints.key(v8Id);
if (id.isValid()) {
BreakpointResponse br = handler->response(id);
if (br.functionName.isEmpty()) {
br.functionName = invocationText;
handler->setResponse(id, br);
}
if (handler->state(id) != BreakpointInserted) {
br.lineNumber = breakData.value(
_("sourceLine")).toInt() + 1;
handler->setResponse(id, br);
handler->notifyBreakpointInsertOk(id);
}
}
}