feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Give a hint to users as to why we didn't do anything

Browse Source 
Task-number: QTCREATORBUG-25565
Change-Id: I27cb0e5bc2a02a88ddf1d42b996e45840d6c1385
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2021-04-12 12:58:52 +02:00
parent 38b4536090
commit 226c03c1eb
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/clangtools/clangtool.cpp
View File

@@ -56,6 +56,7 @@
#include <projectexplorer/projectexplorericons.h>
#include <projectexplorer/session.h>
#include <projectexplorer/target.h>
#include <projectexplorer/taskhub.h>
#include <texteditor/textdocument.h>
@@ -650,6 +651,8 @@ void ClangTool::startTool(ClangTool::FileSelection fileSelection,
return;
}
TaskHub::clearTasks(taskCategory());
// Collect files to analyze
const FileInfos fileInfos = collectFileInfos(project, fileSelection);
if (fileInfos.empty())
@@ -726,8 +729,12 @@ FileInfos ClangTool::collectFileInfos(Project *project, FileSelection fileSelect
FileSelectionType *selectionType = get_if<FileSelectionType>(&fileSelection);
// early bailout
if (selectionType && *selectionType == FileSelectionType::CurrentFile
&& !EditorManager::currentDocument())
&& !EditorManager::currentDocument()) {
TaskHub::addTask(Task::Error, tr("Cannot analyze current file: No files open."),
taskCategory());
TaskHub::requestPopup();
return {};
}
auto projectInfo = CppTools::CppModelManager::instance()->projectInfo(project);
QTC_ASSERT(projectInfo.isValid(), return FileInfos());
@@ -757,6 +764,11 @@ FileInfos ClangTool::collectFileInfos(Project *project, FileSelection fileSelect
});
if (!fileInfo.file.isEmpty())
return {fileInfo};
TaskHub::addTask(Task::Error,
tr("Cannot analyze current file: \"%1\" is not a known source file.")
.arg(filePath.toUserOutput()),
taskCategory());
TaskHub::requestPopup();
}
return {};