feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: prevent accessing nullptr

Browse Source 
There is a certain amount of time between resetting the processor to
nullptr in ClangdFollowSymbol::VirtualFunctionAssistProcessor::cancel
and the destruction of the ClangdFollowSymbol sentinel. So we also need
to check the processor before calling update.

Task-number: QTCREATORBUG-28769
Change-Id: Idec7c9dd7648285ecf2360c309d9751303f6209c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
David Schulz
2023-02-07 09:08:23 +01:00
parent 516fce6f53
commit 2293488536
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/clangcodemodel/clangdfollowsymbol.cpp
View File

@@ -453,7 +453,7 @@ void ClangdFollowSymbol::Private::handleGotoImplementationResult(
const QString &name, const QString &prefix, const MessageId &reqId) { const QString &name, const QString &prefix, const MessageId &reqId) {
qCDebug(clangdLog) << "handling symbol info reply" qCDebug(clangdLog) << "handling symbol info reply"
<< link.targetFilePath.toUserOutput() << link.targetLine; << link.targetFilePath.toUserOutput() << link.targetLine;
if (!sentinel) if (!sentinel || !virtualFuncAssistProcessor)
return; return;
if (!name.isEmpty()) if (!name.isEmpty())
symbolsToDisplay.push_back({prefix + name, link}); symbolsToDisplay.push_back({prefix + name, link});