feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Copilot: Use normal checkboxes in settings

Browse Source 
We usually do not use the "Label [ ]" style, at the very least it looks
different to other places in the settings. And without a ":"
("Label: [ ]") it also looks different to other lines in the same page.
Just use normal checkboxes like we do elsewhere.

Change-Id: I7f7d7aab399bef50dacb1efd83a5da460237e044
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
Eike Ziller
2023-10-18 10:54:18 +02:00
parent e6ecfa0517
commit 22c1d34e64
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/copilot/copilotsettings.cpp
View File

@@ -93,14 +93,12 @@ CopilotSettings::CopilotSettings()
autoComplete.setDefaultValue(true); autoComplete.setDefaultValue(true);
autoComplete.setToolTip(Tr::tr("Automatically request suggestions for the current text cursor " autoComplete.setToolTip(Tr::tr("Automatically request suggestions for the current text cursor "
"position after changes to the document.")); "position after changes to the document."));
autoComplete.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
useProxy.setDisplayName(Tr::tr("Use Proxy")); useProxy.setDisplayName(Tr::tr("Use Proxy"));
useProxy.setSettingsKey("Copilot.UseProxy"); useProxy.setSettingsKey("Copilot.UseProxy");
useProxy.setLabelText(Tr::tr("Use proxy")); useProxy.setLabelText(Tr::tr("Use proxy"));
useProxy.setDefaultValue(false); useProxy.setDefaultValue(false);
useProxy.setToolTip(Tr::tr("Use a proxy to connect to the Copilot servers.")); useProxy.setToolTip(Tr::tr("Use a proxy to connect to the Copilot servers."));
useProxy.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
proxyHost.setDisplayName(Tr::tr("Proxy Host")); proxyHost.setDisplayName(Tr::tr("Proxy Host"));
proxyHost.setDisplayStyle(StringAspect::LineEditDisplay); proxyHost.setDisplayStyle(StringAspect::LineEditDisplay);
@@ -131,7 +129,6 @@ CopilotSettings::CopilotSettings()
saveProxyPassword.setDefaultValue(false); saveProxyPassword.setDefaultValue(false);
saveProxyPassword.setToolTip( saveProxyPassword.setToolTip(
Tr::tr("Save the password to access the proxy server. The password is stored insecurely.")); Tr::tr("Save the password to access the proxy server. The password is stored insecurely."));
saveProxyPassword.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
proxyPassword.setDisplayName(Tr::tr("Proxy Password")); proxyPassword.setDisplayName(Tr::tr("Proxy Password"));
proxyPassword.setDisplayStyle(StringAspect::PasswordLineEditDisplay); proxyPassword.setDisplayStyle(StringAspect::PasswordLineEditDisplay);
@@ -146,10 +143,8 @@ CopilotSettings::CopilotSettings()
proxyRejectUnauthorized.setDefaultValue(true); proxyRejectUnauthorized.setDefaultValue(true);
proxyRejectUnauthorized.setToolTip(Tr::tr("Reject unauthorized certificates from the proxy " proxyRejectUnauthorized.setToolTip(Tr::tr("Reject unauthorized certificates from the proxy "
"server. This is a security risk.")); "server. This is a security risk."));
proxyRejectUnauthorized.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
initEnableAspect(enableCopilot); initEnableAspect(enableCopilot);
enableCopilot.setLabelPlacement(BoolAspect::LabelPlacement::InExtraLabel);
readSettings(); readSettings();