feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Target: Make constructor private

Browse Source 
Use Project::createTarget consistently

Change-Id: Ic8b60f35a830080d325758c93bca7068c9859c59
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-11-16 17:10:55 +01:00
parent f133ca30e3
commit 22e3a7b3a4
3 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/projectexplorer/target.h
View File

@@ -59,7 +59,6 @@ class PROJECTEXPLORER_EXPORT Target : public ProjectConfiguration
Q_OBJECT Q_OBJECT
public: public:
Target(Project *parent, Kit *k);
~Target() override; ~Target() override;
Project *project() const; Project *project() const;
@@ -158,6 +157,7 @@ signals:
void buildDirectoryChanged(); void buildDirectoryChanged();
private: private:
Target(Project *parent, Kit *k);
void setEnabled(bool); void setEnabled(bool);
bool fromMap(const QVariantMap &map) override; bool fromMap(const QVariantMap &map) override;
@@ -169,7 +169,6 @@ private:
void changeBuildConfigurationEnabled(); void changeBuildConfigurationEnabled();
void changeDeployConfigurationEnabled(); void changeDeployConfigurationEnabled();
void changeRunConfigurationEnabled(); void changeRunConfigurationEnabled();
void handleKitUpdates(ProjectExplorer::Kit *k); void handleKitUpdates(ProjectExplorer::Kit *k);
void handleKitRemoval(ProjectExplorer::Kit *k); void handleKitRemoval(ProjectExplorer::Kit *k);

2
src/plugins/pythoneditor/pythoneditorplugin.cpp
View File

@@ -863,7 +863,7 @@ Project::RestoreResult PythonProject::fromMap(const QVariantMap &map, QString *e
if (res == RestoreResult::Ok) { if (res == RestoreResult::Ok) {
Kit *defaultKit = KitManager::defaultKit(); Kit *defaultKit = KitManager::defaultKit();
if (!activeTarget() && defaultKit) if (!activeTarget() && defaultKit)
addTarget(new Target(this, defaultKit)); addTarget(createTarget(defaultKit));
refresh(); refresh();

9
src/plugins/qbsprojectmanager/qbsproject.cpp
View File

@@ -606,13 +606,8 @@ Project::RestoreResult QbsProject::fromMap(const QVariantMap &map, QString *erro
return result; return result;
Kit *defaultKit = KitManager::defaultKit(); Kit *defaultKit = KitManager::defaultKit();
if (!activeTarget() && defaultKit) { if (!activeTarget() && defaultKit)
Target *t = new Target(this, defaultKit); addTarget(createTarget(defaultKit));
t->updateDefaultBuildConfigurations();
t->updateDefaultDeployConfigurations();
t->updateDefaultRunConfigurations();
addTarget(t);
}
return RestoreResult::Ok; return RestoreResult::Ok;
} }