feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Launch feedback dialog only from design mode

Browse Source 
Task-number: QDS-9641
Change-Id: I1d2523c8cd019092b4c64fdefeb326e0751bbb37
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
This commit is contained in:
Thomas Hartmann
2023-04-20 18:49:46 +02:00
parent 3387c68ff2
commit 22f08280f5
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/qmldesigner/qmldesignerplugin.cpp
View File

@@ -243,7 +243,7 @@ bool QmlDesignerPlugin::initialize(const QStringList & /*arguments*/, QString *e
->addAction(cmd, Core::Constants::G_HELP_SUPPORT); ->addAction(cmd, Core::Constants::G_HELP_SUPPORT);
connect(action, &QAction::triggered, this, [this] { connect(action, &QAction::triggered, this, [this] {
lauchFeedbackPopup(Core::Constants::IDE_DISPLAY_NAME); lauchFeedbackPopupInternal(Core::Constants::IDE_DISPLAY_NAME);
}); });
if (!Utils::HostOsInfo::canCreateOpenGLContext(errorMessage)) if (!Utils::HostOsInfo::canCreateOpenGLContext(errorMessage))
@@ -732,6 +732,18 @@ void QmlDesignerPlugin::trackWidgetFocusTime(QWidget *widget, const QString &ide
} }
void QmlDesignerPlugin::lauchFeedbackPopup(const QString &identifier) void QmlDesignerPlugin::lauchFeedbackPopup(const QString &identifier)
{
if (Core::ModeManager::currentModeId() == Core::Constants::MODE_DESIGN)
lauchFeedbackPopupInternal(identifier);
}
void QmlDesignerPlugin::handleFeedback(const QString &feedback, int rating)
{
const QString identifier = sender()->property("identifier").toString();
emit usageStatisticsInsertFeedback(identifier, feedback, rating);
}
void QmlDesignerPlugin::lauchFeedbackPopupInternal(const QString &identifier)
{ {
m_feedbackWidget = new QQuickWidget(Core::ICore::dialogParent()); m_feedbackWidget = new QQuickWidget(Core::ICore::dialogParent());
m_feedbackWidget->setObjectName(Constants::OBJECT_NAME_TOP_FEEDBACK); m_feedbackWidget->setObjectName(Constants::OBJECT_NAME_TOP_FEEDBACK);
@@ -769,12 +781,6 @@ void QmlDesignerPlugin::lauchFeedbackPopup(const QString &identifier)
m_feedbackWidget->show(); m_feedbackWidget->show();
} }
void QmlDesignerPlugin::handleFeedback(const QString &feedback, int rating)
{
const QString identifier = sender()->property("identifier").toString();
emit usageStatisticsInsertFeedback(identifier, feedback, rating);
}
void QmlDesignerPlugin::closeFeedbackPopup() void QmlDesignerPlugin::closeFeedbackPopup()
{ {
if (m_feedbackWidget) { if (m_feedbackWidget) {

1
src/plugins/qmldesigner/qmldesignerplugin.h
View File

@@ -95,6 +95,7 @@ private slots:
void handleFeedback(const QString &feedback, int rating); void handleFeedback(const QString &feedback, int rating);
private: // functions private: // functions
void lauchFeedbackPopupInternal(const QString &identifier);
void integrateIntoQtCreator(QWidget *modeWidget); void integrateIntoQtCreator(QWidget *modeWidget);
void showDesigner(); void showDesigner();
void hideDesigner(); void hideDesigner();