feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ModelEditor: Fix crash when selecting items

Browse Source 
Fixes: QTCREATORBUG-30413
Change-Id: Ie637e20d6308da2e1afcf3ff710f29c6a1695d58
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Marcus Tillmanns
2024-03-07 13:00:21 +01:00
parent c936fc5982
commit 22f41fb751
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/modelinglib/qmt/diagram_scene/diagramscenemodel.cpp
View File

@@ -507,7 +507,9 @@ void DiagramSceneModel::selectItem(QGraphicsItem *item, bool multiSelect)
{ {
if (!multiSelect) { if (!multiSelect) {
if (!item->isSelected()) { if (!item->isSelected()) {
for (QGraphicsItem *selectedItem : std::as_const(m_selectedItems)) { // We have to create a copy since "setSelected" may modify m_selectedItems
const QSet<QGraphicsItem *> copy = m_selectedItems;
for (QGraphicsItem *selectedItem : copy) {
if (selectedItem != item) if (selectedItem != item)
selectedItem->setSelected(false); selectedItem->setSelected(false);
} }