From 230741f5a9ca9f9ea62871cdb6452935e1a1d45c Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 19 Dec 2019 14:13:33 +0100 Subject: [PATCH] ProjectExplorer: Remove enabledChanged emissions ... from *RunConfiguration::setUpdater implementations. The RunConfiguration::update() emits it unconditionally nowadays. Change-Id: I0a67b760ea611026bd2357f59090166be8e0d6b3 Reviewed-by: Christian Kandeler --- src/plugins/baremetal/baremetalrunconfiguration.cpp | 1 - src/plugins/projectexplorer/desktoprunconfiguration.cpp | 2 -- src/plugins/qnx/qnxrunconfiguration.cpp | 1 - src/plugins/remotelinux/remotelinuxrunconfiguration.cpp | 2 -- 4 files changed, 6 deletions(-) diff --git a/src/plugins/baremetal/baremetalrunconfiguration.cpp b/src/plugins/baremetal/baremetalrunconfiguration.cpp index 4712d7fca82..d0cab4e3a52 100644 --- a/src/plugins/baremetal/baremetalrunconfiguration.cpp +++ b/src/plugins/baremetal/baremetalrunconfiguration.cpp @@ -53,7 +53,6 @@ BareMetalRunConfiguration::BareMetalRunConfiguration(Target *target, Core::Id id setUpdater([this, exeAspect] { const BuildTargetInfo bti = buildTargetInfo(); exeAspect->setExecutable(bti.targetFilePath); - emit enabledChanged(); }); connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update); diff --git a/src/plugins/projectexplorer/desktoprunconfiguration.cpp b/src/plugins/projectexplorer/desktoprunconfiguration.cpp index 9d58490081e..838c99f289d 100644 --- a/src/plugins/projectexplorer/desktoprunconfiguration.cpp +++ b/src/plugins/projectexplorer/desktoprunconfiguration.cpp @@ -124,8 +124,6 @@ void DesktopRunConfiguration::updateTargetInformation() aspect()->setDefaultWorkingDirectory(defaultWorkingDir); } - emit enabledChanged(); - } else if (m_kind == CMake) { aspect()->setExecutable(bti.targetFilePath); diff --git a/src/plugins/qnx/qnxrunconfiguration.cpp b/src/plugins/qnx/qnxrunconfiguration.cpp index edbdc90d19f..7e948bc49b7 100644 --- a/src/plugins/qnx/qnxrunconfiguration.cpp +++ b/src/plugins/qnx/qnxrunconfiguration.cpp @@ -76,7 +76,6 @@ QnxRunConfiguration::QnxRunConfiguration(Target *target, Core::Id id) .deployableForLocalFile(localExecutable); exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath())); symbolsAspect->setFilePath(localExecutable); - emit enabledChanged(); }); connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update); diff --git a/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp b/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp index 2f351c27082..f519352b3b2 100644 --- a/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp +++ b/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp @@ -76,8 +76,6 @@ RemoteLinuxRunConfiguration::RemoteLinuxRunConfiguration(Target *target, Core::I exeAspect->setExecutable(FilePath::fromString(depFile.remoteFilePath())); symbolsAspect->setFilePath(localExecutable); - - emit enabledChanged(); }); connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update);