feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix for changing type

Browse Source 
The type of the root node is handled differently.

Change-Id: I360095c97184230502c8d80fbcb7ef7815f0a177
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Thomas Hartmann
2017-01-03 14:12:54 +01:00
parent 477e5e6b7e
commit 2322f70fb6
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmldesigner/components/propertyeditor/propertyeditorcontextobject.cpp
View File

@@ -187,7 +187,10 @@ void PropertyEditorContextObject::changeTypeName(const QString &typeName)
Core::AsynchronousMessageBox::warning(tr("Invalid Type"), tr("%1 is an invalid type.").arg(typeName)); Core::AsynchronousMessageBox::warning(tr("Invalid Type"), tr("%1 is an invalid type.").arg(typeName));
return; return;
} }
selectedNode.changeType(metaInfo.typeName(), metaInfo.majorVersion(), metaInfo.minorVersion()); if (selectedNode.isRootNode())
rewriterView->changeRootNodeType(metaInfo.typeName(), metaInfo.majorVersion(), metaInfo.minorVersion());
else
selectedNode.changeType(metaInfo.typeName(), metaInfo.majorVersion(), metaInfo.minorVersion());
transaction.commit(); transaction.commit();
} catch (RewritingException &exception) { //better safe than sorry! There always might be cases where we fail } catch (RewritingException &exception) { //better safe than sorry! There always might be cases where we fail