From 2387b56012002dde4bae26f02ec72561e8936b10 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Mon, 7 Sep 2020 13:51:00 +0300 Subject: [PATCH] QmlDesigner: Don't set ALWAYS_SAVE_IN_CRUMBLEBAR when no changes in qml Core::DocumentManager::saveModifiedDocument doesn't set the alwaysSave flag if there is nothing to save, which led to undefined results as the flag was left to uninitialized state. Change-Id: I9417775241123b9e1bb3b57b6ced96bc555fb635 Fixes: QDS-2718 Reviewed-by: Mahmoud Badri --- .../qmldesigner/components/componentcore/crumblebar.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmldesigner/components/componentcore/crumblebar.cpp b/src/plugins/qmldesigner/components/componentcore/crumblebar.cpp index 8494e2093b3..073a69168c9 100644 --- a/src/plugins/qmldesigner/components/componentcore/crumblebar.cpp +++ b/src/plugins/qmldesigner/components/componentcore/crumblebar.cpp @@ -135,10 +135,10 @@ Utils::CrumblePath *CrumbleBar::crumblePath() void CrumbleBar::showSaveDialog() { - if (DesignerSettings::getValue(DesignerSettingsKey::ALWAYS_SAVE_IN_CRUMBLEBAR).toBool()) { + bool alwaysSave = DesignerSettings::getValue(DesignerSettingsKey::ALWAYS_SAVE_IN_CRUMBLEBAR).toBool(); + if (alwaysSave) { Core::DocumentManager::saveModifiedDocumentSilently(currentDesignDocument()->editor()->document()); } else { - bool alwaysSave; bool canceled; Core::DocumentManager::saveModifiedDocument(currentDesignDocument()->editor()->document(),