feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SubversionPlugin: Introduce member initialization.

Browse Source 
Change-Id: Ib242ebdadf858cf64dbce8799699f024d7368204
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
This commit is contained in:
Jarek Kobus
2015-06-18 15:23:57 +02:00
parent 9ba80c699c
commit 23880f77de
3 changed files with 30 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/subversion/subversionclient.cpp
View File

@@ -180,14 +180,13 @@ private:
const SubversionClient *m_client; const SubversionClient *m_client;
QString m_workingDirectory; QString m_workingDirectory;
QStringList m_filesList; QStringList m_filesList;
int m_changeNumber; int m_changeNumber = 0;
}; };
DiffController::DiffController(IDocument *document, const SubversionClient *client, const QString &directory) : DiffController::DiffController(IDocument *document, const SubversionClient *client, const QString &directory) :
DiffEditorController(document), DiffEditorController(document),
m_client(client), m_client(client),
m_workingDirectory(directory), m_workingDirectory(directory)
m_changeNumber(0)
{ {
forceContextLineCount(3); // SVN can not change that when using internal diff forceContextLineCount(3); // SVN can not change that when using internal diff
} }

28
src/plugins/subversion/subversionplugin.cpp
View File

@@ -175,33 +175,7 @@ static inline QStringList svnDirectories()
SubversionPlugin *SubversionPlugin::m_subversionPluginInstance = 0; SubversionPlugin *SubversionPlugin::m_subversionPluginInstance = 0;
SubversionPlugin::SubversionPlugin() : SubversionPlugin::SubversionPlugin() :
m_svnDirectories(svnDirectories()), m_svnDirectories(svnDirectories())
m_commandLocator(0),
m_addAction(0),
m_deleteAction(0),
m_revertAction(0),
m_diffProjectAction(0),
m_diffCurrentAction(0),
m_logProjectAction(0),
m_logRepositoryAction(0),
m_commitAllAction(0),
m_revertRepositoryAction(0),
m_diffRepositoryAction(0),
m_statusRepositoryAction(0),
m_updateRepositoryAction(0),
m_commitCurrentAction(0),
m_filelogCurrentAction(0),
m_annotateCurrentAction(0),
m_statusProjectAction(0),
m_updateProjectAction(0),
m_commitProjectAction(0),
m_describeAction(0),
m_submitCurrentLogAction(0),
m_submitDiffAction(0),
m_submitUndoAction(0),
m_submitRedoAction(0),
m_menuAction(0),
m_submitActionTriggered(false)
{ {
} }

55
src/plugins/subversion/subversionplugin.h
View File

@@ -57,8 +57,7 @@ class SubversionClient;
struct SubversionResponse struct SubversionResponse
{ {
SubversionResponse() : error(false) {} bool error = false;
bool error;
QString stdOut; QString stdOut;
QString stdErr; QString stdErr;
QString message; QString message;
@@ -153,33 +152,33 @@ private:
QString m_commitMessageFileName; QString m_commitMessageFileName;
QString m_commitRepository; QString m_commitRepository;
Core::CommandLocator *m_commandLocator; Core::CommandLocator *m_commandLocator = nullptr;
Utils::ParameterAction *m_addAction; Utils::ParameterAction *m_addAction = nullptr;
Utils::ParameterAction *m_deleteAction; Utils::ParameterAction *m_deleteAction = nullptr;
Utils::ParameterAction *m_revertAction; Utils::ParameterAction *m_revertAction = nullptr;
Utils::ParameterAction *m_diffProjectAction; Utils::ParameterAction *m_diffProjectAction = nullptr;
Utils::ParameterAction *m_diffCurrentAction; Utils::ParameterAction *m_diffCurrentAction = nullptr;
Utils::ParameterAction *m_logProjectAction; Utils::ParameterAction *m_logProjectAction = nullptr;
QAction *m_logRepositoryAction; QAction *m_logRepositoryAction = nullptr;
QAction *m_commitAllAction; QAction *m_commitAllAction = nullptr;
QAction *m_revertRepositoryAction; QAction *m_revertRepositoryAction = nullptr;
QAction *m_diffRepositoryAction; QAction *m_diffRepositoryAction = nullptr;
QAction *m_statusRepositoryAction; QAction *m_statusRepositoryAction = nullptr;
QAction *m_updateRepositoryAction; QAction *m_updateRepositoryAction = nullptr;
Utils::ParameterAction *m_commitCurrentAction; Utils::ParameterAction *m_commitCurrentAction = nullptr;
Utils::ParameterAction *m_filelogCurrentAction; Utils::ParameterAction *m_filelogCurrentAction = nullptr;
Utils::ParameterAction *m_annotateCurrentAction; Utils::ParameterAction *m_annotateCurrentAction = nullptr;
Utils::ParameterAction *m_statusProjectAction; Utils::ParameterAction *m_statusProjectAction = nullptr;
Utils::ParameterAction *m_updateProjectAction; Utils::ParameterAction *m_updateProjectAction = nullptr;
Utils::ParameterAction *m_commitProjectAction; Utils::ParameterAction *m_commitProjectAction = nullptr;
QAction *m_describeAction; QAction *m_describeAction = nullptr;
QAction *m_submitCurrentLogAction; QAction *m_submitCurrentLogAction = nullptr;
QAction *m_submitDiffAction; QAction *m_submitDiffAction = nullptr;
QAction *m_submitUndoAction; QAction *m_submitUndoAction = nullptr;
QAction *m_submitRedoAction; QAction *m_submitRedoAction = nullptr;
QAction *m_menuAction; QAction *m_menuAction = nullptr;
bool m_submitActionTriggered; bool m_submitActionTriggered = false;
static SubversionPlugin *m_subversionPluginInstance; static SubversionPlugin *m_subversionPluginInstance;
}; };