forked from qt-creator/qt-creator
Fix running as root
There is no need for TerminalRunner::setRunAsRoot() as debugger is already being run as root. Implement runAsRoot for non-terminal QtcProcess, too. Fixes: QTCREATORBUG-26964 Change-Id: Id5110db86b7b809a5608714464241cee73875f2b Reviewed-by: <github-actions-qt-creator@cristianadam.eu> Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
@@ -142,7 +142,6 @@ public:
|
||||
QProcess::ProcessError m_error = QProcess::UnknownError;
|
||||
QString m_errorString;
|
||||
bool m_abortOnMetaChars = true;
|
||||
bool m_runAsRoot = false;
|
||||
|
||||
// Used on Unix only
|
||||
QtcProcess m_process;
|
||||
@@ -431,8 +430,6 @@ void TerminalProcess::start()
|
||||
+ QLatin1String("/" RELATIVE_LIBEXEC_PATH "/qtcreator_process_stub");
|
||||
|
||||
QStringList allArgs = terminalArgs.toUnixArgs();
|
||||
if (d->m_runAsRoot)
|
||||
allArgs << "sudo" << "-A";
|
||||
|
||||
allArgs << stubPath
|
||||
<< modeOption(d->m_terminalMode)
|
||||
@@ -797,11 +794,6 @@ const Environment &TerminalProcess::environment() const
|
||||
return d->m_environment;
|
||||
}
|
||||
|
||||
void TerminalProcess::setRunAsRoot(bool on)
|
||||
{
|
||||
d->m_runAsRoot = on;
|
||||
}
|
||||
|
||||
QProcess::ProcessError TerminalProcess::error() const
|
||||
{
|
||||
return d->m_error;
|
||||
|
||||
Reference in New Issue
Block a user