From 23c578c4782e54ada8c2ea01758a5732651aeb96 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Fri, 18 Jan 2019 15:27:05 +0100
Subject: [PATCH] ProjectExplorer: Make DeployConfiguration final

There are no derived classes anymore.

It turns out that the isEnabled() and disabledReason() functions
are unused. Remove them.

Change-Id: I0e79729e87cb68d938115e704fb8e45c24ba1013
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 src/plugins/projectexplorer/deployconfiguration.cpp | 10 ----------
 src/plugins/projectexplorer/deployconfiguration.h   | 10 ++--------
 2 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/src/plugins/projectexplorer/deployconfiguration.cpp b/src/plugins/projectexplorer/deployconfiguration.cpp
index 5bb84f4f6c9..bf716554675 100644
--- a/src/plugins/projectexplorer/deployconfiguration.cpp
+++ b/src/plugins/projectexplorer/deployconfiguration.cpp
@@ -83,16 +83,6 @@ QVariantMap DeployConfiguration::toMap() const
     return map;
 }
 
-bool DeployConfiguration::isEnabled() const
-{
-    return false;
-}
-
-QString DeployConfiguration::disabledReason() const
-{
-    return QString();
-}
-
 bool DeployConfiguration::fromMap(const QVariantMap &map)
 {
     if (!ProjectConfiguration::fromMap(map))
diff --git a/src/plugins/projectexplorer/deployconfiguration.h b/src/plugins/projectexplorer/deployconfiguration.h
index 4c146f9ee8e..706d97958b8 100644
--- a/src/plugins/projectexplorer/deployconfiguration.h
+++ b/src/plugins/projectexplorer/deployconfiguration.h
@@ -37,11 +37,11 @@ class Target;
 class DeployConfigurationFactory;
 class NamedWidget;
 
-class PROJECTEXPLORER_EXPORT DeployConfiguration : public ProjectConfiguration
+class PROJECTEXPLORER_EXPORT DeployConfiguration final : public ProjectConfiguration
 {
     Q_OBJECT
 
-protected:
+private:
     friend class DeployConfigurationFactory;
     explicit DeployConfiguration(Target *target, Core::Id id);
 
@@ -56,17 +56,11 @@ public:
     bool fromMap(const QVariantMap &map) override;
     QVariantMap toMap() const override;
 
-    virtual bool isEnabled() const;
-    virtual QString disabledReason() const;
-
     Target *target() const;
     Project *project() const override;
 
     bool isActive() const override;
 
-signals:
-    void enabledChanged();
-
 private:
     BuildStepList m_stepList;
     std::function<NamedWidget *(Target *)> m_configWidgetCreator;