feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Split off runtime-only items from DebuggerStartParameters

Browse Source 
Right now, DebuggerStartParameter is part of the debugger plugin
external interface. Better not make it fatter than necessary.

Change-Id: I3b9205089f971dd314ccba1335b5ca2d4d9fe7c6
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This commit is contained in:
hjk
2015-05-27 13:59:56 +02:00
parent 28d2b16165
commit 244cdb7804
36 changed files with 543 additions and 516 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/debugger/gdb/coregdbadapter.cpp
View File

@@ -56,7 +56,7 @@ namespace Internal {
//
///////////////////////////////////////////////////////////////////////
GdbCoreEngine::GdbCoreEngine(const DebuggerStartParameters &startParameters)
GdbCoreEngine::GdbCoreEngine(const DebuggerRunParameters &startParameters)
: GdbEngine(startParameters),
m_coreUnpackProcess(0)
{}
@@ -82,9 +82,9 @@ void GdbCoreEngine::setupEngine()
QTC_ASSERT(state() == EngineSetupRequested, qDebug() << state());
showMessage(_("TRYING TO START ADAPTER"));
const DebuggerStartParameters &sp = startParameters();
m_executable = sp.executable;
QFileInfo fi(sp.coreFile);
const DebuggerRunParameters &rp = runParameters();
m_executable = rp.executable;
QFileInfo fi(rp.coreFile);
m_coreName = fi.absoluteFilePath();
unpackCoreIfNeeded();
@@ -178,7 +178,7 @@ void GdbCoreEngine::continueSetupEngine()
}
if (isCore && m_executable.isEmpty()) {
GdbCoreEngine::CoreInfo cinfo = readExecutableNameFromCore(
startParameters().debuggerCommand,
runParameters().debuggerCommand,
coreFileName());
if (cinfo.isCore) {
@@ -253,7 +253,7 @@ void GdbCoreEngine::handleTargetCore(const DebuggerResponse &response)
postCommand("p 5", NoFlags, CB(handleRoundTrip));
return;
}
showStatusMessage(tr("Attach to core \"%1\" failed:").arg(startParameters().coreFile)
showStatusMessage(tr("Attach to core \"%1\" failed:").arg(runParameters().coreFile)
+ QLatin1Char('\n') + QString::fromLocal8Bit(response.data["msg"].data()));
notifyEngineIll();
}