Code cosmetics

Mostly unused #include's, also sort them or reduce scope.

A few namespaces, ...

Change-Id: I9ee71e07de7157c9942125672addf87dd41e78f1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>

src/plugins/android/androiddevice.cpp

@@ -38,6 +38,7 @@
 #include <projectexplorer/devicesupport/devicemanager.h>
 #include <projectexplorer/devicesupport/idevicewidget.h>
 #include <projectexplorer/kitinformation.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>

src/plugins/android/androidqmlpreviewworker.cpp

@@ -28,7 +28,6 @@
 #include "androidavdmanager.h"
 #include "androiddevice.h"
 #include "androiddeviceinfo.h"
-#include "androidglobal.h"
 #include "androidmanager.h"
 
 #include <coreplugin/icore.h>
@@ -38,6 +37,7 @@
 #include <projectexplorer/environmentaspect.h>
 #include <projectexplorer/kit.h>
 #include <projectexplorer/project.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 
 #include <qmlprojectmanager/qmlprojectconstants.h>

src/plugins/android/androidqmlpreviewworker.h

@@ -24,6 +24,7 @@
 ****************************************************************************/
 
 #pragma once
+
 #include "androidconfigurations.h"
 
 #include <projectexplorer/runcontrol.h>

src/plugins/baremetal/baremetalplugin.cpp

@@ -45,6 +45,7 @@
 #include <coreplugin/icore.h>
 
 #include <projectexplorer/deployconfiguration.h>
+#include <projectexplorer/projectexplorerconstants.h>
 
 using namespace ProjectExplorer;
 

src/plugins/boot2qt/qdbmakedefaultappstep.cpp

@@ -28,6 +28,7 @@
 #include "qdbconstants.h"
 
 #include <projectexplorer/devicesupport/idevice.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
 #include <projectexplorer/target.h>
 

src/plugins/clangcodemodel/clangcodemodelplugin.cpp

@@ -47,6 +47,7 @@
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectpanelfactory.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/taskhub.h>

src/plugins/clangtools/clangtool.cpp

@@ -33,7 +33,6 @@
 #include "clangtoolsdiagnosticmodel.h"
 #include "clangtoolsdiagnosticview.h"
 #include "clangtoolslogfilereader.h"
-#include "clangtoolsplugin.h"
 #include "clangtoolsprojectsettings.h"
 #include "clangtoolssettings.h"
 #include "clangtoolsutils.h"
@@ -54,6 +53,7 @@
 #include <projectexplorer/buildconfiguration.h>
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectexplorericons.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>

src/plugins/clangtools/clangtoolsunittests.cpp

@@ -28,16 +28,18 @@
 #include "clangtool.h"
 #include "clangtoolsdiagnostic.h"
 #include "clangtoolssettings.h"
-#include "clangtoolsutils.h"
 
 #include <coreplugin/icore.h>
+
 #include <cppeditor/clangdiagnosticconfig.h>
 #include <cppeditor/cppmodelmanager.h>
 #include <cppeditor/cpptoolsreuse.h>
 #include <cppeditor/cpptoolstestcase.h>
+
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/kitmanager.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/toolchain.h>
 
 #include <qtsupport/qtkitinformation.h>

src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp

@@ -55,6 +55,7 @@
 #include <projectexplorer/namedwidget.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/taskhub.h>
 

src/plugins/cmakeprojectmanager/cmakebuildstep.cpp

@@ -39,6 +39,7 @@
 #include <projectexplorer/processparameters.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/xcodebuildparser.h>

src/plugins/compilationdatabaseprojectmanager/compilationdatabasetests.cpp

@@ -30,11 +30,14 @@
 #include <coreplugin/icore.h>
 #include <cppeditor/cpptoolstestcase.h>
 #include <cppeditor/projectinfo.h>
+
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/kitmanager.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/toolchain.h>
 #include <projectexplorer/toolchainmanager.h>
+
 #include <utils/algorithm.h>
 #include <utils/hostosinfo.h>
 

src/plugins/cppcheck/cppcheckplugin.cpp

@@ -32,10 +32,11 @@
 #include "cppcheckdiagnosticsmodel.h"
 #include "cppcheckmanualrundialog.h"
 
-#include <projectexplorer/session.h>
-#include <projectexplorer/projectexplorer.h>
-#include <projectexplorer/project.h>
 #include <projectexplorer/kitinformation.h>
+#include <projectexplorer/project.h>
+#include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
+#include <projectexplorer/session.h>
 #include <projectexplorer/target.h>
 
 #include <coreplugin/actionmanager/actioncontainer.h>

src/plugins/cppeditor/cppmodelmanager.cpp

@@ -32,19 +32,16 @@
 #include "cppcodemodelinspectordumper.h"
 #include "cppcurrentdocumentfilter.h"
 #include "cppeditorconstants.h"
-#include "cppeditorplugin.h"
 #include "cppfindreferences.h"
 #include "cppincludesfilter.h"
 #include "cppindexingsupport.h"
 #include "cpplocatordata.h"
 #include "cpplocatorfilter.h"
 #include "cppbuiltinmodelmanagersupport.h"
-#include "cpprefactoringchanges.h"
 #include "cppsourceprocessor.h"
 #include "cpptoolsjsextension.h"
 #include "cpptoolsreuse.h"
 #include "editordocumenthandle.h"
-#include "stringtable.h"
 #include "symbolfinder.h"
 #include "symbolsfindfilter.h"
 
@@ -57,13 +54,17 @@
 #include <cplusplus/ASTPath.h>
 #include <cplusplus/TypeOfExpression.h>
 #include <extensionsystem/pluginmanager.h>
+
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/kitmanager.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectmacro.h>
 #include <projectexplorer/session.h>
+
 #include <texteditor/textdocument.h>
+
 #include <utils/fileutils.h>
 #include <utils/hostosinfo.h>
 #include <utils/qtcassert.h>

src/plugins/debugger/loadcoredialog.cpp

@@ -32,6 +32,8 @@
 #include <projectexplorer/devicesupport/filetransfer.h>
 #include <projectexplorer/devicesupport/idevice.h>
 #include <projectexplorer/kitchooser.h>
+#include <projectexplorer/projectexplorerconstants.h>
+
 #include <utils/pathchooser.h>
 #include <utils/processinterface.h>
 #include <utils/qtcassert.h>

src/plugins/debugger/loadcoredialog.h

@@ -35,8 +35,6 @@ namespace Utils { class FilePath; }
 namespace Debugger {
 namespace Internal {
 
-class AttachCoreDialogPrivate;
-
 class AttachCoreDialog : public QDialog
 {
     Q_OBJECT
@@ -71,9 +69,8 @@ private:
     void coreFileChanged(const QString &core);
     void selectRemoteCoreFile();
 
-    AttachCoreDialogPrivate *d;
+    class AttachCoreDialogPrivate *d;
 };
 
-
 } // namespace Debugger
 } // namespace Internal

src/plugins/debugger/unstartedappwatcherdialog.cpp

@@ -26,29 +26,31 @@
 #include "unstartedappwatcherdialog.h"
 
 #include "debuggeritem.h"
-#include "debuggerdialogs.h"
 #include "debuggerkitinformation.h"
 
 #include <utils/pathchooser.h>
 
+#include <projectexplorer/buildconfiguration.h>
 #include <projectexplorer/kit.h>
-#include <projectexplorer/target.h>
+#include <projectexplorer/kitchooser.h>
-#include <projectexplorer/project.h>
 #include <projectexplorer/kitmanager.h>
+#include <projectexplorer/project.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projecttree.h>
 #include <projectexplorer/runconfiguration.h>
-#include <projectexplorer/buildconfiguration.h>
+#include <projectexplorer/runcontrol.h>
+#include <projectexplorer/target.h>
 
-#include <QVBoxLayout>
-#include <QHBoxLayout>
-#include <QPushButton>
 #include <QCheckBox>
 #include <QDialogButtonBox>
+#include <QFileDialog>
+#include <QFormLayout>
+#include <QHBoxLayout>
 #include <QKeyEvent>
 #include <QLabel>
-#include <QFormLayout>
 #include <QLineEdit>
-#include <QFileDialog>
+#include <QPushButton>
+#include <QVBoxLayout>
 
 using namespace ProjectExplorer;
 using namespace Utils;

src/plugins/mcusupport/mcukitmanager.cpp

@@ -37,13 +37,18 @@
 #include <cmakeprojectmanager/cmakekitinformation.h>
 #include <cmakeprojectmanager/cmaketoolmanager.h>
 #include <coreplugin/icore.h>
+
 #include <debugger/debuggeritem.h>
 #include <debugger/debuggeritemmanager.h>
 #include <debugger/debuggerkitinformation.h>
-#include <utils/algorithm.h>
+
+#include <projectexplorer/projectexplorerconstants.h>
+
 #include <qtsupport/qtkitinformation.h>
 #include <qtsupport/qtversionmanager.h>
 
+#include <utils/algorithm.h>
+
 #include <QMessageBox>
 #include <QPushButton>
 

src/plugins/mcusupport/mcusupportplugin.cpp

@@ -44,6 +44,7 @@
 #include <projectexplorer/devicesupport/devicemanager.h>
 #include <projectexplorer/jsonwizard/jsonwizardfactory.h>
 #include <projectexplorer/kitmanager.h>
+#include <projectexplorer/projectexplorerconstants.h>
 
 #include <utils/infobar.h>
 

src/plugins/mcusupport/test/unittest.cpp

@@ -49,11 +49,14 @@
 #include <cmakeprojectmanager/cmakekitinformation.h>
 #include <gmock/gmock-actions.h>
 #include <gmock/gmock.h>
+
 #include <projectexplorer/customtoolchain.h>
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/toolchain.h>
 #include <projectexplorer/toolchainmanager.h>
+
 #include <utils/algorithm.h>
 #include <utils/filepath.h>
 

src/plugins/mesonprojectmanager/mesonactionsmanager/mesonactionsmanager.cpp

@@ -31,7 +31,9 @@
 
 #include <project/mesonbuildsystem.h>
 #include <project/projecttree/mesonprojectnodes.h>
+
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projecttree.h>
 
 #include <utils/parameteraction.h>

src/plugins/mesonprojectmanager/mesonprojectplugin.cpp

@@ -25,11 +25,9 @@
 
 #include "mesonprojectplugin.h"
 
-#include "exewrappers/mesonwrapper.h"
 #include "machinefiles/machinefilemanager.h"
 #include "mesonactionsmanager/mesonactionsmanager.h"
 #include "project/mesonbuildconfiguration.h"
-#include "project/mesonbuildsystem.h"
 #include "project/mesonproject.h"
 #include "project/mesonrunconfiguration.h"
 #include "project/ninjabuildstep.h"
@@ -39,8 +37,10 @@
 #include "settings/tools/toolssettingsaccessor.h"
 #include "settings/tools/toolssettingspage.h"
 
+#include <coreplugin/fileiconprovider.h>
 #include <coreplugin/icore.h>
 
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectmanager.h>
 #include <projectexplorer/runcontrol.h>
 

src/plugins/mesonprojectmanager/project/mesonrunconfiguration.cpp

@@ -31,7 +31,9 @@
 #include <projectexplorer/desktoprunconfiguration.h>
 #include <projectexplorer/environmentaspect.h>
 #include <projectexplorer/localenvironmentaspect.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
+#include <projectexplorer/target.h>
 
 #include <utils/environment.h>
 #include <utils/hostosinfo.h>

src/plugins/mesonprojectmanager/project/mesonrunconfiguration.h

@@ -25,9 +25,7 @@
 
 #pragma once
 
-#include <projectexplorer/desktoprunconfiguration.h>
 #include <projectexplorer/runconfiguration.h>
-#include <projectexplorer/target.h>
 
 namespace MesonProjectManager {
 namespace Internal {

src/plugins/nim/nimplugin.cpp

@@ -27,7 +27,6 @@
 
 #include "nimconstants.h"
 #include "editor/nimeditorfactory.h"
-#include "editor/nimhighlighter.h"
 #include "project/nimblerunconfiguration.h"
 #include "project/nimblebuildconfiguration.h"
 #include "project/nimbuildconfiguration.h"
@@ -45,10 +44,13 @@
 #include "suggest/nimsuggestcache.h"
 
 #include <coreplugin/fileiconprovider.h>
+
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectmanager.h>
-#include <projectexplorer/toolchainmanager.h>
 #include <projectexplorer/runcontrol.h>
 #include <projectexplorer/taskhub.h>
+#include <projectexplorer/toolchainmanager.h>
+
 #include <texteditor/snippets/snippetprovider.h>
 
 using namespace Utils;

src/plugins/nim/project/nimblerunconfiguration.cpp

@@ -25,11 +25,11 @@
 
 #include "nimblerunconfiguration.h"
 
-#include "nimblebuildsystem.h"
+#include "nimbuildsystem.h"
 #include "nimconstants.h"
-#include "nimbleproject.h"
 
 #include <projectexplorer/localenvironmentaspect.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
 #include <projectexplorer/runcontrol.h>
 #include <projectexplorer/target.h>

src/plugins/perfprofiler/perfprofilerplugin.cpp

@@ -24,12 +24,10 @@
 ****************************************************************************/
 
 #include "perfoptionspage.h"
-#include "perfprofilerconstants.h"
 #include "perfprofilerplugin.h"
 #include "perfprofilerruncontrol.h"
 #include "perfprofilertool.h"
 #include "perfrunconfigurationaspect.h"
-#include "perftimelinemodelmanager.h"
 
 #if WITH_TESTS
 //#  include "tests/perfprofilertracefile_test.h"    // FIXME has to be rewritten
@@ -44,8 +42,10 @@
 #include <coreplugin/icore.h>
 #include <debugger/analyzer/analyzermanager.h>
 #include <extensionsystem/pluginmanager.h>
+
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/project.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/target.h>
 

src/plugins/perfprofiler/perfprofilertool.cpp

@@ -26,9 +26,7 @@
 #include "perfconfigwidget.h"
 #include "perfloaddialog.h"
 #include "perfprofilerplugin.h"
-#include "perfprofilerruncontrol.h"
 #include "perfprofilertool.h"
-#include "perfrunconfigurationaspect.h"
 #include "perfsettings.h"
 #include "perftracepointdialog.h"
 
@@ -39,15 +37,20 @@
 #include <coreplugin/imode.h>
 #include <coreplugin/messagebox.h>
 #include <coreplugin/modemanager.h>
+
 #include <debugger/analyzer/analyzerconstants.h>
 #include <debugger/analyzer/analyzermanager.h>
 #include <debugger/debuggericons.h>
+
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>
+
 #include <qtsupport/qtkitinformation.h>
+
 #include <utils/algorithm.h>
 #include <utils/fancymainwindow.h>
 #include <utils/utilsicons.h>

src/plugins/projectexplorer/buildsteplist.cpp

@@ -25,11 +25,9 @@
 
 #include "buildsteplist.h"
 
-#include "buildconfiguration.h"
 #include "buildmanager.h"
 #include "buildstep.h"
-#include "deployconfiguration.h"
+#include "projectexplorerconstants.h"
-#include "projectexplorer.h"
 #include "target.h"
 
 #include <utils/algorithm.h>

src/plugins/projectexplorer/buildsystem.h

@@ -29,7 +29,7 @@
 
 #include "buildtargetinfo.h"
 #include "project.h"
-#include "treescanner.h"
+#include "projectnodes.h"
 
 #include <QObject>
 

src/plugins/projectexplorer/customexecutablerunconfiguration.cpp

@@ -26,6 +26,7 @@
 #include "customexecutablerunconfiguration.h"
 
 #include "localenvironmentaspect.h"
+#include "projectexplorerconstants.h"
 #include "target.h"
 
 using namespace Utils;

src/plugins/projectexplorer/deployconfiguration.cpp

@@ -26,14 +26,16 @@
 #include "deployconfiguration.h"
 
 #include "buildsteplist.h"
-#include "buildconfiguration.h"
 #include "deploymentdataview.h"
 #include "kitinformation.h"
 #include "project.h"
-#include "projectexplorer.h"
+#include "projectexplorerconstants.h"
 #include "target.h"
 
 #include <utils/algorithm.h>
+#include <utils/qtcassert.h>
+
+#include <QDebug>
 
 using namespace Utils;
 
@@ -44,7 +46,7 @@ const char BUILD_STEP_LIST_PREFIX[] = "ProjectExplorer.BuildConfiguration.BuildS
 const char USES_DEPLOYMENT_DATA[] = "ProjectExplorer.DeployConfiguration.CustomDataEnabled";
 const char DEPLOYMENT_DATA[] = "ProjectExplorer.DeployConfiguration.CustomData";
 
-DeployConfiguration::DeployConfiguration(Target *target, Utils::Id id)
+DeployConfiguration::DeployConfiguration(Target *target, Id id)
     : ProjectConfiguration(target, id),
       m_stepList(this, Constants::BUILDSTEPS_DEPLOY)
 {
@@ -135,7 +137,7 @@ DeployConfigurationFactory::~DeployConfigurationFactory()
     g_deployConfigurationFactories.removeOne(this);
 }
 
-Utils::Id DeployConfigurationFactory::creationId() const
+Id DeployConfigurationFactory::creationId() const
 {
     return m_deployConfigBaseId;
 }
@@ -176,7 +178,7 @@ void DeployConfigurationFactory::setUseDeploymentDataView()
     };
 }
 
-void DeployConfigurationFactory::setConfigBaseId(Utils::Id deployConfigBaseId)
+void DeployConfigurationFactory::setConfigBaseId(Id deployConfigBaseId)
 {
     m_deployConfigBaseId = deployConfigBaseId;
 }
@@ -210,7 +212,7 @@ DeployConfiguration *DeployConfigurationFactory::clone(Target *parent,
 
 DeployConfiguration *DeployConfigurationFactory::restore(Target *parent, const QVariantMap &map)
 {
-    const Utils::Id id = idFromMap(map);
+    const Id id = idFromMap(map);
     DeployConfigurationFactory *factory = Utils::findOrDefault(g_deployConfigurationFactories,
         [parent, id](DeployConfigurationFactory *f) {
             if (!f->canHandle(parent))

src/plugins/projectexplorer/desktoprunconfiguration.cpp

@@ -27,7 +27,7 @@
 
 #include "buildsystem.h"
 #include "localenvironmentaspect.h"
-#include "project.h"
+#include "projectexplorerconstants.h"
 #include "runconfigurationaspects.h"
 #include "target.h"
 

src/plugins/projectexplorer/desktoprunconfiguration.h

@@ -25,8 +25,7 @@
 
 #pragma once
 
-#include "runconfigurationaspects.h"
+#include "runconfiguration.h"
-#include "runcontrol.h"
 
 namespace ProjectExplorer {
 namespace Internal {

src/plugins/projectexplorer/miniprojecttargetselector.cpp

@@ -23,16 +23,17 @@
 **
 ****************************************************************************/
 
+#include "miniprojecttargetselector.h"
+
 #include "buildconfiguration.h"
 #include "buildmanager.h"
 #include "deployconfiguration.h"
 #include "kit.h"
 #include "kitmanager.h"
-#include "miniprojecttargetselector.h"
-#include "projectexplorer.h"
-#include "projectexplorericons.h"
 #include "project.h"
-#include "projectmodels.h"
+#include "projectexplorer.h"
+#include "projectexplorerconstants.h"
+#include "projectexplorericons.h"
 #include "runconfiguration.h"
 #include "session.h"
 #include "target.h"
@@ -44,25 +45,26 @@
 #include <utils/styledbar.h>
 #include <utils/stylehelper.h>
 #include <utils/theme/theme.h>
+#include <utils/treemodel.h>
 #include <utils/utilsicons.h>
 
-#include <coreplugin/icore.h>
 #include <coreplugin/coreconstants.h>
+#include <coreplugin/icore.h>
 #include <coreplugin/modemanager.h>
 
+#include <QAction>
 #include <QGuiApplication>
-#include <QTimer>
+#include <QItemDelegate>
-#include <QLayout>
+#include <QKeyEvent>
 #include <QLabel>
+#include <QLayout>
 #include <QList>
 #include <QListWidget>
-#include <QStatusBar>
-#include <QKeyEvent>
 #include <QPainter>
 #include <QPixmap>
+#include <QStatusBar>
 #include <QStyleFactory>
-#include <QAction>
+#include <QTimer>
-#include <QItemDelegate>
 
 using namespace Utils;
 

src/plugins/projectexplorer/project.cpp

@@ -33,6 +33,7 @@
 #include "kit.h"
 #include "kitinformation.h"
 #include "projectexplorer.h"
+#include "projectexplorerconstants.h"
 #include "projectnodes.h"
 #include "runconfiguration.h"
 #include "session.h"
@@ -54,6 +55,7 @@
 
 #include <utils/algorithm.h>
 #include <utils/environment.h>
+#include <utils/fileutils.h>
 #include <utils/macroexpander.h>
 #include <utils/pointeralgorithm.h>
 #include <utils/qtcassert.h>

src/plugins/projectexplorer/project.h

@@ -33,9 +33,8 @@
 #include <coreplugin/idocument.h>
 
 #include <utils/environmentfwd.h>
-#include <utils/fileutils.h>
+#include <utils/filepath.h>
 
-#include <QObject>
 #include <QFileSystemModel>
 
 #include <functional>

src/plugins/projectexplorer/projectfilewizardextension.cpp

@@ -24,34 +24,36 @@
 ****************************************************************************/
 
 #include "projectfilewizardextension.h"
-#include "projectexplorer.h"
+
-#include "session.h"
+#include "editorconfiguration.h"
+#include "project.h"
+#include "projectexplorerconstants.h"
 #include "projectnodes.h"
 #include "projecttree.h"
+#include "projecttree.h"
 #include "projectwizardpage.h"
-
+#include "session.h"
-#include <utils/algorithm.h>
-#include <utils/qtcassert.h>
-#include <utils/stringutils.h>
 
 #include <coreplugin/icore.h>
-#include <projectexplorer/editorconfiguration.h>
+
-#include <projectexplorer/project.h>
-#include <projectexplorer/projecttree.h>
 #include <texteditor/icodestylepreferences.h>
 #include <texteditor/icodestylepreferencesfactory.h>
 #include <texteditor/storagesettings.h>
 #include <texteditor/tabsettings.h>
 #include <texteditor/texteditorsettings.h>
 #include <texteditor/textindenter.h>
-#include <utils/mimeutils.h>
 
-#include <QPointer>
+#include <utils/algorithm.h>
+#include <utils/mimeutils.h>
+#include <utils/qtcassert.h>
+#include <utils/stringutils.h>
+
 #include <QDebug>
 #include <QFileInfo>
-#include <QTextDocument>
-#include <QTextCursor>
 #include <QMessageBox>
+#include <QPointer>
+#include <QTextCursor>
+#include <QTextDocument>
 
 using namespace TextEditor;
 using namespace Core;
@@ -76,7 +78,6 @@ using namespace Utils;
 enum { debugExtension = 0 };
 
 namespace ProjectExplorer {
-
 namespace Internal {
 
 // --------- ProjectWizardContext

src/plugins/projectexplorer/projecttreewidget.cpp

@@ -25,12 +25,12 @@
 
 #include "projecttreewidget.h"
 
-#include "projectexplorer.h"
-#include "projectnodes.h"
 #include "project.h"
-#include "session.h"
+#include "projectexplorerconstants.h"
 #include "projectmodels.h"
+#include "projectnodes.h"
 #include "projecttree.h"
+#include "session.h"
 
 #include <coreplugin/actionmanager/actionmanager.h>
 #include <coreplugin/actionmanager/command.h>
@@ -44,19 +44,19 @@
 #include <utils/algorithm.h>
 #include <utils/navigationtreeview.h>
 #include <utils/progressindicator.h>
+#include <utils/qtcassert.h>
 #include <utils/tooltip/tooltip.h>
 #include <utils/utilsicons.h>
 
-#include <QApplication>
-#include <QSettings>
-
-#include <QStyledItemDelegate>
-#include <QVBoxLayout>
-#include <QToolButton>
-#include <QPainter>
 #include <QAction>
+#include <QApplication>
 #include <QLineEdit>
 #include <QMenu>
+#include <QPainter>
+#include <QSettings>
+#include <QStyledItemDelegate>
+#include <QToolButton>
+#include <QVBoxLayout>
 
 #include <memory>
 
@@ -469,11 +469,11 @@ void ProjectTreeWidget::editCurrentItem()
     const Node *node = m_model->nodeForIndex(currentIndex);
     if (!node)
         return;
-    auto *editor = qobject_cast<QLineEdit*>(m_view->indexWidget(currentIndex));
+    auto editor = qobject_cast<QLineEdit *>(m_view->indexWidget(currentIndex));
     if (!editor)
         return;
 
-    const int dotIndex = Utils::FilePath::fromString(editor->text()).completeBaseName().length();
+    const int dotIndex = FilePath::fromString(editor->text()).completeBaseName().length();
     if (dotIndex > 0)
         editor->setSelection(0, dotIndex);
 }

src/plugins/projectexplorer/projecttreewidget.h

@@ -25,15 +25,12 @@
 
 #pragma once
 
-#include "expanddata.h"
-
 #include <coreplugin/inavigationwidgetfactory.h>
 
-#include <utils/fileutils.h>
+#include <utils/filepath.h>
 
 #include <QWidget>
 #include <QModelIndex>
-#include <QSet>
 
 QT_FORWARD_DECLARE_CLASS(QTreeView)
 

src/plugins/projectexplorer/runconfiguration.cpp

@@ -25,7 +25,6 @@
 
 #include "runconfiguration.h"
 
-#include "abi.h"
 #include "buildconfiguration.h"
 #include "buildsystem.h"
 #include "environmentaspect.h"
@@ -33,16 +32,19 @@
 #include "kitinformation.h"
 #include "project.h"
 #include "projectexplorer.h"
+#include "projectexplorerconstants.h"
 #include "projectnodes.h"
 #include "runconfigurationaspects.h"
 #include "runcontrol.h"
 #include "session.h"
 #include "target.h"
-#include "toolchain.h"
 
 #include <coreplugin/icontext.h>
 #include <coreplugin/icore.h>
+
 #include <projectexplorer/devicesupport/idevice.h>
+#include <projectexplorer/projectexplorerconstants.h>
+
 #include <utils/algorithm.h>
 #include <utils/checkablemessagebox.h>
 #include <utils/detailswidget.h>

src/plugins/projectexplorer/runconfiguration.h

@@ -27,7 +27,6 @@
 
 #include "buildtargetinfo.h"
 #include "projectconfiguration.h"
-#include "projectexplorerconstants.h"
 #include "task.h"
 
 #include <utils/aspects.h>

src/plugins/projectexplorer/session.cpp

@@ -31,6 +31,7 @@
 #include "kit.h"
 #include "project.h"
 #include "projectexplorer.h"
+#include "projectexplorerconstants.h"
 #include "projectnodes.h"
 #include "target.h"
 
@@ -51,7 +52,6 @@
 #include <QDebug>
 #include <QDir>
 #include <QFileInfo>
-
 #include <QMessageBox>
 #include <QPushButton>
 

src/plugins/projectexplorer/toolchainsettingsaccessor.cpp

@@ -25,6 +25,7 @@
 
 #include "toolchainsettingsaccessor.h"
 
+#include "projectexplorerconstants.h"
 #include "toolchain.h"
 
 #include <coreplugin/icore.h>
@@ -56,9 +57,9 @@ public:
 // Helpers:
 // --------------------------------------------------------------------
 
-static const char TOOLCHAIN_DATA_KEY[] = "ToolChain.";
+const char TOOLCHAIN_DATA_KEY[] = "ToolChain.";
-static const char TOOLCHAIN_COUNT_KEY[] = "ToolChain.Count";
+const char TOOLCHAIN_COUNT_KEY[] = "ToolChain.Count";
-static const char TOOLCHAIN_FILENAME[] = "toolchains.xml";
+const char TOOLCHAIN_FILENAME[] = "toolchains.xml";
 
 struct ToolChainOperations
 {
@@ -284,8 +285,6 @@ Toolchains ToolChainSettingsAccessor::toolChains(const QVariantMap &data) const
 #ifdef WITH_TESTS
 #include "projectexplorer.h"
 
-#include "headerpath.h"
-
 #include "abi.h"
 #include "toolchainconfigwidget.h"
 

src/plugins/projectexplorer/toolchainsettingsaccessor.h

@@ -29,8 +29,6 @@
 
 #include <QList>
 
-#include <memory>
-
 namespace ProjectExplorer {
 
 class ToolChain;

src/plugins/projectexplorer/treescanner.h

@@ -28,7 +28,7 @@
 #include "projectexplorer_export.h"
 #include "projectnodes.h"
 
-#include <utils/fileutils.h>
+#include <utils/filepath.h>
 #include <utils/mimeutils.h>
 
 #include <QObject>

src/plugins/python/pythonplugin.cpp

@@ -26,9 +26,7 @@
 #include "pythonplugin.h"
 
 #include "pysidebuildconfiguration.h"
-#include "pythonconstants.h"
 #include "pythoneditor.h"
-#include "pythonlanguageclient.h"
 #include "pythonproject.h"
 #include "pythonsettings.h"
 #include "pythonrunconfiguration.h"
@@ -37,6 +35,7 @@
 
 #include <projectexplorer/buildtargetinfo.h>
 #include <projectexplorer/localenvironmentaspect.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectmanager.h>
 #include <projectexplorer/runcontrol.h>
 #include <projectexplorer/taskhub.h>

src/plugins/python/pythonproject.cpp

@@ -50,6 +50,7 @@
 
 #include <utils/algorithm.h>
 #include <utils/fileutils.h>
+#include <utils/mimeutils.h>
 
 using namespace Core;
 using namespace ProjectExplorer;

src/plugins/qmakeprojectmanager/qmakenodes.cpp

@@ -28,6 +28,7 @@
 #include "qmakeproject.h"
 
 #include <projectexplorer/buildconfiguration.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/target.h>
 

src/plugins/qmakeprojectmanager/qmakenodes.h

@@ -31,9 +31,8 @@
 #include <projectexplorer/buildsystem.h>
 #include <projectexplorer/projectnodes.h>
 
-namespace Utils { class FilePath; }
-
 namespace QmakeProjectManager {
+
 class QmakeProFileNode;
 class QmakeProject;
 

src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.cpp

@@ -38,7 +38,6 @@
 #include "qmakeproject.h"
 #include "externaleditors.h"
 #include "qmakekitinformation.h"
-#include "profilehighlighter.h"
 
 #include <coreplugin/icore.h>
 #include <coreplugin/coreconstants.h>
@@ -56,6 +55,7 @@
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectexplorericons.h>
 
 #include <texteditor/texteditor.h>

src/plugins/qmakeprojectmanager/qmakeprojectmanagerplugin.h

@@ -27,12 +27,7 @@
 
 #include <extensionsystem/iplugin.h>
 
-namespace ProjectExplorer { class Project; }
-
 namespace QmakeProjectManager {
-
-class QmakeProFileNode;
-
 namespace Internal {
 
 class QmakeProjectManagerPlugin final : public ExtensionSystem::IPlugin

src/plugins/qmakeprojectmanager/qmakestep.cpp

@@ -25,7 +25,6 @@
 
 #include "qmakestep.h"
 
-#include "qmakemakestep.h"
 #include "qmakebuildconfiguration.h"
 #include "qmakekitinformation.h"
 #include "qmakenodes.h"
@@ -39,8 +38,10 @@
 #include <projectexplorer/buildmanager.h>
 #include <projectexplorer/buildsteplist.h>
 #include <projectexplorer/gnumakeparser.h>
+#include <projectexplorer/makestep.h>
 #include <projectexplorer/processparameters.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/toolchain.h>

src/plugins/qmldesigner/qmlpreviewplugin/qmlpreviewactions.cpp

@@ -30,8 +30,10 @@
 #include <designersettings.h>
 
 #include <utils/utilsicons.h>
+
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/target.h>

src/plugins/qmlpreview/qmlpreviewplugin.cpp

@@ -44,6 +44,7 @@
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectnodes.h>
 #include <projectexplorer/projecttree.h>
 #include <projectexplorer/runconfiguration.h>

src/plugins/qmlprofiler/qmlprofilerplugin.cpp

@@ -28,7 +28,6 @@
 #include "qmlprofilerruncontrol.h"
 #include "qmlprofilersettings.h"
 #include "qmlprofilertool.h"
-#include "qmlprofilertimelinemodel.h"
 #include "qmlprofileractions.h"
 
 #ifdef WITH_TESTS
@@ -65,6 +64,7 @@
 
 #include <projectexplorer/environmentaspect.h>
 #include <projectexplorer/kitinformation.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/target.h>
 

src/plugins/qmlprofiler/qmlprofilertool.cpp

@@ -31,8 +31,6 @@
 #include "qmlprofilerviewmanager.h"
 #include "qmlprofilerclientmanager.h"
 #include "qmlprofilermodelmanager.h"
-#include "qmlprofilerdetailsrewriter.h"
-#include "qmlprofilernotesmodel.h"
 #include "qmlprofilerrunconfigurationaspect.h"
 #include "qmlprofilersettings.h"
 #include "qmlprofilerplugin.h"
@@ -59,8 +57,9 @@
 #include <projectexplorer/devicesupport/idevice.h>
 #include <projectexplorer/environmentaspect.h>
 #include <projectexplorer/kitinformation.h>
-#include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/project.h>
+#include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/taskhub.h>

src/plugins/qmlprofiler/qmlprofilertool.h

@@ -26,8 +26,6 @@
 #pragma once
 
 #include "qmlprofiler_global.h"
-#include "qmlprofilerconstants.h"
-#include "qmlprofilereventtypes.h"
 
 #include <QAction>
 #include <QObject>

src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp

@@ -25,12 +25,15 @@
 
 #include "qmlprofilerviewmanager.h"
 
-#include "qmlprofilertool.h"
+#include "qmlprofilerconstants.h"
 #include "qmlprofilerstatewidget.h"
 
-#include <utils/qtcassert.h>
 #include <debugger/analyzer/analyzermanager.h>
 
+#include <projectexplorer/projectexplorerconstants.h>
+
+#include <utils/qtcassert.h>
+
 #include <QDockWidget>
 
 using namespace Debugger;
@@ -51,7 +54,7 @@ QmlProfilerViewManager::QmlProfilerViewManager(QObject *parent,
     QTC_ASSERT(m_profilerModelManager, return);
     QTC_ASSERT(m_profilerState, return);
 
-    m_perspective = new Utils::Perspective(Constants::QmlProfilerPerspectiveId, tr("QML Profiler"));
+    m_perspective = new Perspective(Constants::QmlProfilerPerspectiveId, tr("QML Profiler"));
     m_perspective->setAboutToActivateCallback([this]() { createViews(); });
 }
 

src/plugins/qmlprofiler/qmlprofilerviewmanager.h

@@ -29,15 +29,11 @@
 #include "qmlprofilertraceview.h"
 #include "flamegraphview.h"
 
-#include <QObject>
-
 namespace Utils { class Perspective; }
 
 namespace QmlProfiler {
 namespace Internal {
 
-class QmlProfilerTool;
-
 class QmlProfilerViewManager : public QObject
 {
     Q_OBJECT

src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp

@@ -27,6 +27,8 @@
 
 #include <debugger/analyzer/analyzermanager.h>
 
+#include <projectexplorer/projectexplorerconstants.h>
+
 #include <qmlprofiler/qmlprofilerruncontrol.h>
 #include <qmlprofiler/qmlprofilertool.h>
 

src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.h

@@ -28,14 +28,13 @@
 #include <qmlprofiler/qmlprofilermodelmanager.h>
 #include <qmlprofiler/qmlprofilerruncontrol.h>
 
-#include <QUrl>
-
 namespace QmlProfiler {
 namespace Internal {
 
 class LocalQmlProfilerRunnerTest : public QObject
 {
     Q_OBJECT
+
 public:
     LocalQmlProfilerRunnerTest(QObject *parent = nullptr);
 

src/plugins/qmlprojectmanager/qmlmainfileaspect.cpp

@@ -34,6 +34,7 @@
 #include <coreplugin/editormanager/ieditor.h>
 
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 
 #include <utils/algorithm.h>

src/plugins/qmlprojectmanager/qmlproject.cpp

@@ -30,8 +30,6 @@
 #include "qmlprojectconstants.h"
 #include "qmlprojectmanagerconstants.h"
 #include "qmlprojectnodes.h"
-#include "qmlprojectplugin.h"
-#include "qmlprojectrunconfiguration.h"
 
 #include <coreplugin/documentmanager.h>
 #include <coreplugin/editormanager/documentmodel.h>
@@ -45,6 +43,7 @@
 #include <projectexplorer/devicesupport/idevice.h>
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/kitmanager.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 
 #include <qtsupport/baseqtversion.h>
@@ -57,6 +56,7 @@
 
 #include <utils/algorithm.h>
 #include <utils/infobar.h>
+#include <utils/qtcassert.h>
 #include <utils/qtcprocess.h>
 
 #include <QDebug>

src/plugins/qmlprojectmanager/qmlproject.h

@@ -26,7 +26,6 @@
 #pragma once
 
 #include "qmlprojectmanager_global.h"
-#include "qmlprojectnodes.h"
 
 #include <projectexplorer/buildsystem.h>
 #include <projectexplorer/project.h>

src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp

@@ -39,6 +39,7 @@
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/kitmanager.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
 #include <projectexplorer/runcontrol.h>
 #include <projectexplorer/session.h>

src/plugins/qtsupport/gettingstartedwelcomepage.cpp

@@ -40,8 +40,10 @@
 #include <coreplugin/helpmanager.h>
 #include <coreplugin/modemanager.h>
 #include <coreplugin/welcomepagehelper.h>
-#include <projectexplorer/projectexplorer.h>
+
 #include <projectexplorer/project.h>
+#include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 
 #include <QComboBox>
 #include <QDesktopServices>

src/plugins/remotelinux/customcommanddeploystep.cpp

@@ -30,6 +30,7 @@
 #include "remotelinux_constants.h"
 
 #include <projectexplorer/devicesupport/idevice.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
 
 #include <utils/qtcprocess.h>

src/plugins/remotelinux/makeinstallstep.cpp

@@ -34,9 +34,11 @@
 #include <projectexplorer/devicesupport/idevice.h>
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/processparameters.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfigurationaspects.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/task.h>
+
 #include <utils/algorithm.h>
 #include <utils/fileutils.h>
 #include <utils/qtcassert.h>

src/plugins/remotelinux/makeinstallstep.h

@@ -30,11 +30,6 @@
 #include <projectexplorer/deploymentdata.h>
 #include <projectexplorer/makestep.h>
 
-namespace Utils {
-class FilePath;
-class StringAspect;
-} // Utils
-
 namespace RemoteLinux {
 
 class REMOTELINUX_EXPORT MakeInstallStep : public ProjectExplorer::MakeStep

src/plugins/remotelinux/remotelinuxplugin.cpp

@@ -46,6 +46,7 @@
 #endif
 
 #include <projectexplorer/kitinformation.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 
 using namespace ProjectExplorer;

src/plugins/valgrind/memchecktool.cpp

@@ -51,6 +51,7 @@
 #include <projectexplorer/kitinformation.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectexplorer.h>
+#include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/runconfiguration.h>
 #include <projectexplorer/session.h>
 #include <projectexplorer/target.h>