feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Analyzer: Remove AnalyzerRunControl::runnable() and .connection()

Browse Source 
These re-implementations are conceptually "too specific". Rather let
the indiviual tools handle there expectations themselves.

Change-Id: I0bbea407b2241816a40d19eb1dbb0a7589cbda7b
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2016-01-28 18:24:08 +01:00
parent b2c6ea47b1
commit 249a36b573
10 changed files with 24 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/valgrind/valgrindengine.cpp
View File

@@ -28,13 +28,15 @@
#include "valgrindsettings.h"
#include "valgrindplugin.h"
#include <analyzerbase/analyzermanager.h>
#include <analyzerbase/analyzerstartparameters.h>
#include <coreplugin/icore.h>
#include <coreplugin/ioutputpane.h>
#include <coreplugin/progressmanager/progressmanager.h>
#include <coreplugin/progressmanager/futureprogress.h>
#include <extensionsystem/pluginmanager.h>
#include <projectexplorer/runconfiguration.h>
#include <analyzerbase/analyzermanager.h>
#include <QApplication>
#include <QMainWindow>
@@ -85,9 +87,9 @@ bool ValgrindRunControl::startEngine()
ValgrindRunner *run = runner();
run->setValgrindExecutable(m_settings->valgrindExecutable());
run->setValgrindArguments(genericToolArguments() + toolArguments());
run->setConnectionParameters(connection().connParams);
run->setConnectionParameters(connection().as<AnalyzerConnection>().connParams);
run->setUseStartupProject(!m_isCustomStart);
run->setDebuggee(runnable());
run->setDebuggee(runnable().as<StandardRunnable>());
connect(run, &ValgrindRunner::processOutputReceived,
this, &ValgrindRunControl::receiveProcessOutput);
@@ -111,7 +113,7 @@ void ValgrindRunControl::stopEngine()
QString ValgrindRunControl::executable() const
{
return runnable().executable;
return runnable().as<StandardRunnable>().executable;
}
QStringList ValgrindRunControl::genericToolArguments() const