feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: remove OptionalLineColumn

Browse Source 
LineColumn already has a isValid() that is sufficient for the use case.

Change-Id: I7f6e1d64b66a9af05d74ce0ef45717265dc28ed3
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
David Schulz
2023-05-09 14:15:38 +02:00
parent 5b0c3258bb
commit 24aea361b7
4 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libs/utils/textutils.cpp
View File

@@ -53,16 +53,13 @@ bool convertPosition(const QTextDocument *document, int pos, int *line, int *col
}
}
OptionalLineColumn convertPosition(const QTextDocument *document, int pos)
LineColumn convertPosition(const QTextDocument *document, int pos)
{
OptionalLineColumn optional;
QTextBlock block = document->findBlock(pos);
const QTextBlock block = document->findBlock(pos);
if (block.isValid())
optional.emplace(block.blockNumber() + 1, pos - block.position());
return {block.blockNumber() + 1, pos - block.position()};
return optional;
return {};
}
int positionInText(const QTextDocument *textDocument, int line, int column)