feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Avoid copy for node path

Browse Source 
It appears to take 7% of project loading...

Change-Id: I2d20d919cc861a6ee95af359a584fb27a915cf80
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This commit is contained in:
Orgad Shaneh
2015-02-27 09:36:54 +02:00
committed by Orgad Shaneh
parent a316948868
commit 25096de511
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/projectnodes.cpp
View File

@@ -155,7 +155,7 @@ FolderNode *Node::parentFolderNode() const
/*! /*!
The path of the file or folder in the filesystem the node represents. The path of the file or folder in the filesystem the node represents.
*/ */
Utils::FileName Node::path() const const Utils::FileName &Node::path() const
{ {
return m_path; return m_path;
} }

2
src/plugins/projectexplorer/projectnodes.h
View File

@@ -112,7 +112,7 @@ public:
NodeType nodeType() const; NodeType nodeType() const;
ProjectNode *projectNode() const; // managing project ProjectNode *projectNode() const; // managing project
FolderNode *parentFolderNode() const; // parent folder or project FolderNode *parentFolderNode() const; // parent folder or project
Utils::FileName path() const; // file system path const Utils::FileName &path() const; // file system path
int line() const; int line() const;
virtual QString displayName() const; virtual QString displayName() const;
virtual QString tooltip() const; virtual QString tooltip() const;

2
src/plugins/resourceeditor/resourcenode.cpp
View File

@@ -286,7 +286,7 @@ bool ResourceTopLevelNode::showInSimpleTree() const
} }
ResourceFolderNode::ResourceFolderNode(const QString &prefix, const QString &lang, ResourceTopLevelNode *parent) ResourceFolderNode::ResourceFolderNode(const QString &prefix, const QString &lang, ResourceTopLevelNode *parent)
: ProjectExplorer::FolderNode(parent->path().appendPath(prefix)), : ProjectExplorer::FolderNode(Utils::FileName(parent->path()).appendPath(prefix)),
// TOOD Why add existing directory doesn't work // TOOD Why add existing directory doesn't work
m_topLevelNode(parent), m_topLevelNode(parent),
m_prefix(prefix), m_prefix(prefix),