feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove RunConfiguration::fillConfigurationLayout

Browse Source 
Instead of using a hard-coded list of well-known (optional) aspects,
add all aspects, so there is no need for special treatment of
RunConfiguration with unusual/custom aspects needed.

Price and benefit is that the individual run configs are again
responsible for the aspect display order which is determined
from the aspect construction order.

Change-Id: Iff2656b2e358c0f0f789d4c006a5c44d0a1536a5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-09-04 08:38:44 +02:00
parent 760e6a9b13
commit 25400751a4
8 changed files with 10 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/pythoneditor/pythoneditorplugin.cpp
View File

@@ -234,7 +234,6 @@ public:
private:
void doAdditionalSetup(const RunConfigurationCreationInfo &) final { updateTargetInformation(); }
void fillConfigurationLayout(QFormLayout *layout) const final;
Runnable runnable() const final;
bool supportsDebugger() const { return true; }
@@ -285,14 +284,6 @@ void PythonRunConfiguration::updateTargetInformation()
extraAspect<MainScriptAspect>()->setValue(script);
}
void PythonRunConfiguration::fillConfigurationLayout(QFormLayout *layout) const
{
extraAspect<InterpreterAspect>()->addToConfigurationLayout(layout);
extraAspect<MainScriptAspect>()->addToConfigurationLayout(layout);
extraAspect<ArgumentsAspect>()->addToConfigurationLayout(layout);
extraAspect<TerminalAspect>()->addToConfigurationLayout(layout);
}
Runnable PythonRunConfiguration::runnable() const
{
Runnable r;