feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use QComboBox::currentTextChanged instead of currentIndexChanged

Browse Source 
QComboBox::currentIndexChanged is depcrecated as of Qt 5.13 and
QComboBox::currentTextChanged is available since Qt 4.1

Change-Id: I97b8eb37765cbb7556cfbde87ea90f91f63bfa63
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Alessandro Portale
2019-05-27 10:24:56 +02:00
parent 4b92b7ac60
commit 25f9d9c434
5 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/qmleditorwidgets/contextpanetextwidget.cpp
View File

@@ -103,7 +103,7 @@ ContextPaneTextWidget::ContextPaneTextWidget(QWidget *parent) :
connect(ui->bottomAlignmentButton, &QToolButton::toggled, connect(ui->bottomAlignmentButton, &QToolButton::toggled,
this, &ContextPaneTextWidget::onVerticalAlignmentChanged); this, &ContextPaneTextWidget::onVerticalAlignmentChanged);
connect(ui->styleComboBox, QOverload<const QString &>::of(&QComboBox::currentIndexChanged), connect(ui->styleComboBox, &QComboBox::currentTextChanged,
this, &ContextPaneTextWidget::onStyleComboBoxChanged); this, &ContextPaneTextWidget::onStyleComboBoxChanged);
} }

3
src/plugins/coreplugin/dialogs/newdialog.cpp
View File

@@ -230,8 +230,7 @@ NewDialog::NewDialog(QWidget *parent) :
connect(m_ui->buttonBox, &QDialogButtonBox::accepted, this, &NewDialog::accept); connect(m_ui->buttonBox, &QDialogButtonBox::accepted, this, &NewDialog::accept);
connect(m_ui->buttonBox, &QDialogButtonBox::rejected, this, &NewDialog::reject); connect(m_ui->buttonBox, &QDialogButtonBox::rejected, this, &NewDialog::reject);
connect(m_ui->comboBox, connect(m_ui->comboBox, &QComboBox::currentTextChanged,
QOverload<const QString &>::of(&QComboBox::currentIndexChanged),
this, &NewDialog::setSelectedPlatform); this, &NewDialog::setSelectedPlatform);
} }

2
src/plugins/scxmleditor/common/colorsettings.cpp
View File

@@ -39,7 +39,7 @@ ColorSettings::ColorSettings(QWidget *parent)
m_ui.setupUi(this); m_ui.setupUi(this);
m_ui.m_colorThemeView->setEnabled(false); m_ui.m_colorThemeView->setEnabled(false);
connect(m_ui.m_comboColorThemes, QOverload<const QString &>::of(&QComboBox::currentIndexChanged), connect(m_ui.m_comboColorThemes, &QComboBox::currentTextChanged,
this, &ColorSettings::selectTheme); this, &ColorSettings::selectTheme);
connect(m_ui.m_colorThemeView, &ColorThemeView::colorChanged, this, &ColorSettings::updateCurrentColors); connect(m_ui.m_colorThemeView, &ColorThemeView::colorChanged, this, &ColorSettings::updateCurrentColors);
connect(m_ui.m_addColorTheme, &QToolButton::clicked, this, &ColorSettings::createTheme); connect(m_ui.m_addColorTheme, &QToolButton::clicked, this, &ColorSettings::createTheme);

3
src/plugins/texteditor/fontsettingspage.cpp
View File

@@ -364,8 +364,7 @@ QWidget *FontSettingsPage::widget()
connect(d_ptr->m_ui->fontComboBox, &QFontComboBox::currentFontChanged, connect(d_ptr->m_ui->fontComboBox, &QFontComboBox::currentFontChanged,
this, &FontSettingsPage::fontSelected); this, &FontSettingsPage::fontSelected);
connect(d_ptr->m_ui->sizeComboBox, connect(d_ptr->m_ui->sizeComboBox, &QComboBox::currentTextChanged,
QOverload<const QString &>::of(&QComboBox::currentIndexChanged),
this, &FontSettingsPage::fontSizeSelected); this, &FontSettingsPage::fontSizeSelected);
connect(d_ptr->m_ui->zoomSpinBox, QOverload<int>::of(&QSpinBox::valueChanged), connect(d_ptr->m_ui->zoomSpinBox, QOverload<int>::of(&QSpinBox::valueChanged),
this, &FontSettingsPage::fontZoomChanged); this, &FontSettingsPage::fontZoomChanged);

3
src/shared/help/bookmarkmanager.cpp
View File

@@ -95,8 +95,7 @@ BookmarkDialog::BookmarkDialog(BookmarkManager *manager, const QString &title,
&QStandardItemModel::itemChanged, &QStandardItemModel::itemChanged,
this, &BookmarkDialog::itemChanged); this, &BookmarkDialog::itemChanged);
connect(ui.bookmarkFolders, connect(ui.bookmarkFolders, &QComboBox::currentTextChanged,
QOverload<const QString &>::of(&QComboBox::currentIndexChanged),
this, &BookmarkDialog::selectBookmarkFolder); this, &BookmarkDialog::selectBookmarkFolder);
connect(ui.treeView, &TreeView::customContextMenuRequested, connect(ui.treeView, &TreeView::customContextMenuRequested,