From 26b409c610fad504f8e838dd05d6a8294d5debed Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 29 Apr 2020 09:50:12 +0200 Subject: [PATCH] Modeling: Avoid undefined behavior With vector based QStringList there's no sequence point between decrement and assignment. Drop the assignment, it's unneeded anyway. Change-Id: Ib88008ec4e3ddada3807ca41fbcc0c981cef5fe3 Reviewed-by: Eike Ziller --- src/libs/modelinglib/qmt/controller/namecontroller.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/modelinglib/qmt/controller/namecontroller.cpp b/src/libs/modelinglib/qmt/controller/namecontroller.cpp index 25ebbc171f3..b336688f041 100644 --- a/src/libs/modelinglib/qmt/controller/namecontroller.cpp +++ b/src/libs/modelinglib/qmt/controller/namecontroller.cpp @@ -138,7 +138,7 @@ QStringList NameController::buildElementsPath(const QString &filePath, bool igno QStringList split = filePath.split("/"); QStringList::const_iterator splitEnd = split.constEnd(); if (ignoreLastFilePathPart || split.last().isEmpty()) - splitEnd = --splitEnd; + --splitEnd; for (auto it = split.constBegin(); it != splitEnd; ++it) { QString packageName = qmt::NameController::convertFileNameToElementName(*it); relativeElements.append(packageName);