From 26bf18e1fefed78a5a4f87df7c02c5d90e9d4686 Mon Sep 17 00:00:00 2001
From: Alessandro Portale <alessandro.portale@qt.io>
Date: Thu, 10 Feb 2022 17:16:04 +0100
Subject: [PATCH] Core: Turn LocatorFilterEntry ofn ILocatorFilter::accept to
 const &

In ILocatorFilter::accept and all the overrides.

Change-Id: I27cd6babb66d91aad57e85572a1cdc77aef4fd79
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
---
 src/plugins/bookmarks/bookmarkfilter.cpp                  | 2 +-
 src/plugins/bookmarks/bookmarkfilter.h                    | 2 +-
 src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp | 2 +-
 src/plugins/clangcodemodel/clangcurrentdocumentfilter.h   | 2 +-
 src/plugins/clangcodemodel/clangdlocatorfilters.cpp       | 4 ++--
 src/plugins/clangcodemodel/clangdlocatorfilters.h         | 4 ++--
 src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp    | 4 ++--
 src/plugins/cmakeprojectmanager/cmakelocatorfilter.h      | 4 ++--
 src/plugins/coreplugin/locator/basefilefilter.cpp         | 2 +-
 src/plugins/coreplugin/locator/basefilefilter.h           | 2 +-
 src/plugins/coreplugin/locator/commandlocator.cpp         | 2 +-
 src/plugins/coreplugin/locator/commandlocator.h           | 2 +-
 src/plugins/coreplugin/locator/executefilter.cpp          | 2 +-
 src/plugins/coreplugin/locator/executefilter.h            | 2 +-
 src/plugins/coreplugin/locator/externaltoolsfilter.cpp    | 2 +-
 src/plugins/coreplugin/locator/externaltoolsfilter.h      | 2 +-
 src/plugins/coreplugin/locator/filesystemfilter.cpp       | 2 +-
 src/plugins/coreplugin/locator/filesystemfilter.h         | 2 +-
 src/plugins/coreplugin/locator/ilocatorfilter.cpp         | 2 +-
 src/plugins/coreplugin/locator/ilocatorfilter.h           | 2 +-
 src/plugins/coreplugin/locator/javascriptfilter.cpp       | 2 +-
 src/plugins/coreplugin/locator/javascriptfilter.h         | 2 +-
 src/plugins/coreplugin/locator/locatorfiltersfilter.cpp   | 2 +-
 src/plugins/coreplugin/locator/locatorfiltersfilter.h     | 2 +-
 src/plugins/coreplugin/locator/opendocumentsfilter.cpp    | 2 +-
 src/plugins/coreplugin/locator/opendocumentsfilter.h      | 2 +-
 src/plugins/coreplugin/locator/urllocatorfilter.cpp       | 2 +-
 src/plugins/coreplugin/locator/urllocatorfilter.h         | 2 +-
 src/plugins/coreplugin/menubarfilter.cpp                  | 2 +-
 src/plugins/coreplugin/menubarfilter.h                    | 2 +-
 src/plugins/cppeditor/cppcurrentdocumentfilter.cpp        | 2 +-
 src/plugins/cppeditor/cppcurrentdocumentfilter.h          | 2 +-
 src/plugins/cppeditor/cpplocatorfilter.cpp                | 2 +-
 src/plugins/cppeditor/cpplocatorfilter.h                  | 2 +-
 src/plugins/help/helpindexfilter.cpp                      | 2 +-
 src/plugins/help/helpindexfilter.h                        | 2 +-
 src/plugins/languageclient/locatorfilter.cpp              | 4 ++--
 src/plugins/languageclient/locatorfilter.h                | 4 ++--
 src/plugins/macros/macrolocatorfilter.cpp                 | 2 +-
 src/plugins/macros/macrolocatorfilter.h                   | 2 +-
 src/plugins/qmljstools/qmljsfunctionfilter.cpp            | 2 +-
 src/plugins/qmljstools/qmljsfunctionfilter.h              | 2 +-
 src/plugins/texteditor/linenumberfilter.cpp               | 2 +-
 src/plugins/texteditor/linenumberfilter.h                 | 2 +-
 44 files changed, 50 insertions(+), 50 deletions(-)

diff --git a/src/plugins/bookmarks/bookmarkfilter.cpp b/src/plugins/bookmarks/bookmarkfilter.cpp
index 28173ffe5d1..594b18e11c9 100644
--- a/src/plugins/bookmarks/bookmarkfilter.cpp
+++ b/src/plugins/bookmarks/bookmarkfilter.cpp
@@ -124,7 +124,7 @@ QList<LocatorFilterEntry> BookmarkFilter::matchesFor(QFutureInterface<LocatorFil
     return m_results;
 }
 
-void BookmarkFilter::accept(LocatorFilterEntry selection, QString *newText,
+void BookmarkFilter::accept(const LocatorFilterEntry &selection, QString *newText,
                             int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/bookmarks/bookmarkfilter.h b/src/plugins/bookmarks/bookmarkfilter.h
index e846436cdbc..4fa9f8e2c11 100644
--- a/src/plugins/bookmarks/bookmarkfilter.h
+++ b/src/plugins/bookmarks/bookmarkfilter.h
@@ -40,7 +40,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                 int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp b/src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp
index ced0fafa76e..47b4803f894 100644
--- a/src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp
+++ b/src/plugins/clangcodemodel/clangcurrentdocumentfilter.cpp
@@ -135,7 +135,7 @@ QList<Core::LocatorFilterEntry> ClangCurrentDocumentFilter::matchesFor(
     return goodEntries;
 }
 
-void ClangCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection,
+void ClangCurrentDocumentFilter::accept(const Core::LocatorFilterEntry &selection,
             QString *, int *, int *) const
 {
     if (!m_currentEditor)
diff --git a/src/plugins/clangcodemodel/clangcurrentdocumentfilter.h b/src/plugins/clangcodemodel/clangcurrentdocumentfilter.h
index 599bbd2d59b..c60d20630f8 100644
--- a/src/plugins/clangcodemodel/clangcurrentdocumentfilter.h
+++ b/src/plugins/clangcodemodel/clangcurrentdocumentfilter.h
@@ -42,7 +42,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/clangcodemodel/clangdlocatorfilters.cpp b/src/plugins/clangcodemodel/clangdlocatorfilters.cpp
index cafd7633d7d..6aa5d1e9703 100644
--- a/src/plugins/clangcodemodel/clangdlocatorfilters.cpp
+++ b/src/plugins/clangcodemodel/clangdlocatorfilters.cpp
@@ -198,7 +198,7 @@ QList<Core::LocatorFilterEntry> ClangGlobalSymbolFilter::matchesFor(
     return matches;
 }
 
-void ClangGlobalSymbolFilter::accept(Core::LocatorFilterEntry selection, QString *newText,
+void ClangGlobalSymbolFilter::accept(const Core::LocatorFilterEntry &selection, QString *newText,
                                      int *selectionStart, int *selectionLength) const
 {
     if (qvariant_cast<CppEditor::IndexItem::Ptr>(selection.internalData))
@@ -318,7 +318,7 @@ QList<Core::LocatorFilterEntry> ClangdCurrentDocumentFilter::matchesFor(
     return d->activeFilter->matchesFor(future, entry);
 }
 
-void ClangdCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection, QString *newText,
+void ClangdCurrentDocumentFilter::accept(const Core::LocatorFilterEntry &selection, QString *newText,
                                          int *selectionStart, int *selectionLength) const
 {
     QTC_ASSERT(d->activeFilter, return);
diff --git a/src/plugins/clangcodemodel/clangdlocatorfilters.h b/src/plugins/clangcodemodel/clangdlocatorfilters.h
index 28341a6a573..bf3f6792820 100644
--- a/src/plugins/clangcodemodel/clangdlocatorfilters.h
+++ b/src/plugins/clangcodemodel/clangdlocatorfilters.h
@@ -41,7 +41,7 @@ private:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                 int *selectionStart, int *selectionLength) const override;
 
     Core::ILocatorFilter * const m_cppFilter;
@@ -70,7 +70,7 @@ private:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                 int *selectionStart, int *selectionLength) const override;
 
     class Private;
diff --git a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
index 9364b155952..ec6d14b9b5e 100644
--- a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
@@ -121,7 +121,7 @@ BuildCMakeTargetLocatorFilter::BuildCMakeTargetLocatorFilter()
     setPriority(High);
 }
 
-void BuildCMakeTargetLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void BuildCMakeTargetLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                            QString *newText,
                                            int *selectionStart,
                                            int *selectionLength) const
@@ -171,7 +171,7 @@ OpenCMakeTargetLocatorFilter::OpenCMakeTargetLocatorFilter()
     setPriority(Medium);
 }
 
-void OpenCMakeTargetLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void OpenCMakeTargetLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                           QString *newText,
                                           int *selectionStart,
                                           int *selectionLength) const
diff --git a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.h b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.h
index 0749e2bb858..99cc87eca68 100644
--- a/src/plugins/cmakeprojectmanager/cmakelocatorfilter.h
+++ b/src/plugins/cmakeprojectmanager/cmakelocatorfilter.h
@@ -54,7 +54,7 @@ class BuildCMakeTargetLocatorFilter : CMakeTargetLocatorFilter
 public:
     BuildCMakeTargetLocatorFilter();
 
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText,
                 int *selectionStart,
                 int *selectionLength) const final;
@@ -67,7 +67,7 @@ class OpenCMakeTargetLocatorFilter : CMakeTargetLocatorFilter
 public:
     OpenCMakeTargetLocatorFilter();
 
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText,
                 int *selectionStart,
                 int *selectionLength) const final;
diff --git a/src/plugins/coreplugin/locator/basefilefilter.cpp b/src/plugins/coreplugin/locator/basefilefilter.cpp
index 8c34e305aac..888db29ac58 100644
--- a/src/plugins/coreplugin/locator/basefilefilter.cpp
+++ b/src/plugins/coreplugin/locator/basefilefilter.cpp
@@ -218,7 +218,7 @@ QList<LocatorFilterEntry> BaseFileFilter::matchesFor(QFutureInterface<LocatorFil
 /*!
     \reimp
 */
-void BaseFileFilter::accept(LocatorFilterEntry selection,
+void BaseFileFilter::accept(const LocatorFilterEntry &selection,
                             QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/locator/basefilefilter.h b/src/plugins/coreplugin/locator/basefilefilter.h
index 84eaa2208a0..0e61d18be46 100644
--- a/src/plugins/coreplugin/locator/basefilefilter.h
+++ b/src/plugins/coreplugin/locator/basefilefilter.h
@@ -68,7 +68,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     static void openEditorAt(const LocatorFilterEntry &selection);
 
diff --git a/src/plugins/coreplugin/locator/commandlocator.cpp b/src/plugins/coreplugin/locator/commandlocator.cpp
index bb8029ce25a..7a803ac1c98 100644
--- a/src/plugins/coreplugin/locator/commandlocator.cpp
+++ b/src/plugins/coreplugin/locator/commandlocator.cpp
@@ -112,7 +112,7 @@ QList<LocatorFilterEntry> CommandLocator::matchesFor(QFutureInterface<LocatorFil
     return betterEntries;
 }
 
-void CommandLocator::accept(LocatorFilterEntry entry,
+void CommandLocator::accept(const LocatorFilterEntry &entry,
                             QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/locator/commandlocator.h b/src/plugins/coreplugin/locator/commandlocator.h
index 9c4efc3e6ee..a59cda20c36 100644
--- a/src/plugins/coreplugin/locator/commandlocator.h
+++ b/src/plugins/coreplugin/locator/commandlocator.h
@@ -48,7 +48,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/coreplugin/locator/executefilter.cpp b/src/plugins/coreplugin/locator/executefilter.cpp
index 7924b8a0053..327731f1e26 100644
--- a/src/plugins/coreplugin/locator/executefilter.cpp
+++ b/src/plugins/coreplugin/locator/executefilter.cpp
@@ -80,7 +80,7 @@ QList<LocatorFilterEntry> ExecuteFilter::matchesFor(QFutureInterface<LocatorFilt
     return value;
 }
 
-void ExecuteFilter::accept(LocatorFilterEntry selection,
+void ExecuteFilter::accept(const LocatorFilterEntry &selection,
                            QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/locator/executefilter.h b/src/plugins/coreplugin/locator/executefilter.h
index d787a2f6ecd..85c84bbb6eb 100644
--- a/src/plugins/coreplugin/locator/executefilter.h
+++ b/src/plugins/coreplugin/locator/executefilter.h
@@ -51,7 +51,7 @@ public:
     ~ExecuteFilter() override;
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp
index 159af87cafc..719f52e59d4 100644
--- a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp
+++ b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp
@@ -49,7 +49,7 @@ QList<LocatorFilterEntry> ExternalToolsFilter::matchesFor(QFutureInterface<Locat
     return m_results;
 }
 
-void ExternalToolsFilter::accept(LocatorFilterEntry selection,
+void ExternalToolsFilter::accept(const LocatorFilterEntry &selection,
                                  QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/locator/externaltoolsfilter.h b/src/plugins/coreplugin/locator/externaltoolsfilter.h
index 519083ac29a..62052c2aee8 100644
--- a/src/plugins/coreplugin/locator/externaltoolsfilter.h
+++ b/src/plugins/coreplugin/locator/externaltoolsfilter.h
@@ -38,7 +38,7 @@ public:
 
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     void prepareSearch(const QString &entry) override;
 
diff --git a/src/plugins/coreplugin/locator/filesystemfilter.cpp b/src/plugins/coreplugin/locator/filesystemfilter.cpp
index 9e0751e570f..08ecb68418a 100644
--- a/src/plugins/coreplugin/locator/filesystemfilter.cpp
+++ b/src/plugins/coreplugin/locator/filesystemfilter.cpp
@@ -169,7 +169,7 @@ QList<LocatorFilterEntry> FileSystemFilter::matchesFor(QFutureInterface<LocatorF
 
 const char kAlwaysCreate[] = "Locator/FileSystemFilter/AlwaysCreate";
 
-void FileSystemFilter::accept(LocatorFilterEntry selection,
+void FileSystemFilter::accept(const LocatorFilterEntry &selection,
                               QString *newText,
                               int *selectionStart,
                               int *selectionLength) const
diff --git a/src/plugins/coreplugin/locator/filesystemfilter.h b/src/plugins/coreplugin/locator/filesystemfilter.h
index f18493515ad..83f21dd841f 100644
--- a/src/plugins/coreplugin/locator/filesystemfilter.h
+++ b/src/plugins/coreplugin/locator/filesystemfilter.h
@@ -45,7 +45,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     void restoreState(const QByteArray &state) override;
     bool openConfigDialog(QWidget *parent, bool &needsRefresh) override;
diff --git a/src/plugins/coreplugin/locator/ilocatorfilter.cpp b/src/plugins/coreplugin/locator/ilocatorfilter.cpp
index aee4fe49065..3d15253ef31 100644
--- a/src/plugins/coreplugin/locator/ilocatorfilter.cpp
+++ b/src/plugins/coreplugin/locator/ilocatorfilter.cpp
@@ -595,7 +595,7 @@ bool ILocatorFilter::isOldSetting(const QByteArray &state)
 */
 
 /*!
-    \fn void Core::ILocatorFilter::accept(Core::LocatorFilterEntry selection, QString *newText, int *selectionStart, int *selectionLength) const
+    \fn void Core::ILocatorFilter::accept(Core::const LocatorFilterEntry &selection, QString *newText, int *selectionStart, int *selectionLength) const
 
     Called with the entry specified by \a selection when the user activates it
     in the result list.
diff --git a/src/plugins/coreplugin/locator/ilocatorfilter.h b/src/plugins/coreplugin/locator/ilocatorfilter.h
index 48679878691..dfcbfc4e67f 100644
--- a/src/plugins/coreplugin/locator/ilocatorfilter.h
+++ b/src/plugins/coreplugin/locator/ilocatorfilter.h
@@ -143,7 +143,7 @@ public:
 
     virtual QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future, const QString &entry) = 0;
 
-    virtual void accept(LocatorFilterEntry selection,
+    virtual void accept(const LocatorFilterEntry &selection,
                         QString *newText, int *selectionStart, int *selectionLength) const = 0;
 
     virtual void refresh(QFutureInterface<void> &future) { Q_UNUSED(future) };
diff --git a/src/plugins/coreplugin/locator/javascriptfilter.cpp b/src/plugins/coreplugin/locator/javascriptfilter.cpp
index 257f133dda8..b15c69f5337 100644
--- a/src/plugins/coreplugin/locator/javascriptfilter.cpp
+++ b/src/plugins/coreplugin/locator/javascriptfilter.cpp
@@ -89,7 +89,7 @@ QList<LocatorFilterEntry> JavaScriptFilter::matchesFor(
     return entries;
 }
 
-void JavaScriptFilter::accept(Core::LocatorFilterEntry selection, QString *newText,
+void JavaScriptFilter::accept(const LocatorFilterEntry &selection, QString *newText,
                               int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/locator/javascriptfilter.h b/src/plugins/coreplugin/locator/javascriptfilter.h
index ccded299900..fffe0ad1b07 100644
--- a/src/plugins/coreplugin/locator/javascriptfilter.h
+++ b/src/plugins/coreplugin/locator/javascriptfilter.h
@@ -49,7 +49,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection, QString *newText,
+    void accept(const Core::LocatorFilterEntry &selection, QString *newText,
                 int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/coreplugin/locator/locatorfiltersfilter.cpp b/src/plugins/coreplugin/locator/locatorfiltersfilter.cpp
index 7b62ff1bf1e..6eed862a5cb 100644
--- a/src/plugins/coreplugin/locator/locatorfiltersfilter.cpp
+++ b/src/plugins/coreplugin/locator/locatorfiltersfilter.cpp
@@ -89,7 +89,7 @@ QList<LocatorFilterEntry> LocatorFiltersFilter::matchesFor(QFutureInterface<Loca
     return entries;
 }
 
-void LocatorFiltersFilter::accept(LocatorFilterEntry selection,
+void LocatorFiltersFilter::accept(const LocatorFilterEntry &selection,
                                   QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(selectionLength)
diff --git a/src/plugins/coreplugin/locator/locatorfiltersfilter.h b/src/plugins/coreplugin/locator/locatorfiltersfilter.h
index c316670fad0..8779d604112 100644
--- a/src/plugins/coreplugin/locator/locatorfiltersfilter.h
+++ b/src/plugins/coreplugin/locator/locatorfiltersfilter.h
@@ -49,7 +49,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/coreplugin/locator/opendocumentsfilter.cpp b/src/plugins/coreplugin/locator/opendocumentsfilter.cpp
index e6aced8d00a..2570c7ea650 100644
--- a/src/plugins/coreplugin/locator/opendocumentsfilter.cpp
+++ b/src/plugins/coreplugin/locator/opendocumentsfilter.cpp
@@ -120,7 +120,7 @@ void OpenDocumentsFilter::refresh(QFutureInterface<void> &future)
     QMetaObject::invokeMethod(this, &OpenDocumentsFilter::refreshInternally, Qt::QueuedConnection);
 }
 
-void OpenDocumentsFilter::accept(LocatorFilterEntry selection,
+void OpenDocumentsFilter::accept(const LocatorFilterEntry &selection,
                                  QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/locator/opendocumentsfilter.h b/src/plugins/coreplugin/locator/opendocumentsfilter.h
index 956dea22d2e..eb9315d1916 100644
--- a/src/plugins/coreplugin/locator/opendocumentsfilter.h
+++ b/src/plugins/coreplugin/locator/opendocumentsfilter.h
@@ -45,7 +45,7 @@ public:
     OpenDocumentsFilter();
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection,
+    void accept(const LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     void refresh(QFutureInterface<void> &future) override;
 
diff --git a/src/plugins/coreplugin/locator/urllocatorfilter.cpp b/src/plugins/coreplugin/locator/urllocatorfilter.cpp
index 2e58cde291e..061c5c49bac 100644
--- a/src/plugins/coreplugin/locator/urllocatorfilter.cpp
+++ b/src/plugins/coreplugin/locator/urllocatorfilter.cpp
@@ -162,7 +162,7 @@ QList<Core::LocatorFilterEntry> UrlLocatorFilter::matchesFor(
     return entries;
 }
 
-void UrlLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void UrlLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                               QString *newText,
                               int *selectionStart,
                               int *selectionLength) const
diff --git a/src/plugins/coreplugin/locator/urllocatorfilter.h b/src/plugins/coreplugin/locator/urllocatorfilter.h
index fdfe8096d3a..8a011a42f41 100644
--- a/src/plugins/coreplugin/locator/urllocatorfilter.h
+++ b/src/plugins/coreplugin/locator/urllocatorfilter.h
@@ -46,7 +46,7 @@ public:
     // ILocatorFilter
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     void restoreState(const QByteArray &state) override;
     bool openConfigDialog(QWidget *parent, bool &needsRefresh) override;
diff --git a/src/plugins/coreplugin/menubarfilter.cpp b/src/plugins/coreplugin/menubarfilter.cpp
index 207959f2d74..4d30763eebf 100644
--- a/src/plugins/coreplugin/menubarfilter.cpp
+++ b/src/plugins/coreplugin/menubarfilter.cpp
@@ -79,7 +79,7 @@ QList<LocatorFilterEntry> MenuBarFilter::matchesFor(QFutureInterface<LocatorFilt
     return std::move(m_entries);
 }
 
-void MenuBarFilter::accept(LocatorFilterEntry selection, QString *newText,
+void MenuBarFilter::accept(const LocatorFilterEntry &selection, QString *newText,
                            int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/coreplugin/menubarfilter.h b/src/plugins/coreplugin/menubarfilter.h
index 62e7dbdc7d3..97b973e6a12 100644
--- a/src/plugins/coreplugin/menubarfilter.h
+++ b/src/plugins/coreplugin/menubarfilter.h
@@ -47,7 +47,7 @@ public:
 
     QList<LocatorFilterEntry> matchesFor(QFutureInterface<LocatorFilterEntry> &future,
                                          const QString &entry) override;
-    void accept(LocatorFilterEntry selection, QString *newText,
+    void accept(const LocatorFilterEntry &selection, QString *newText,
                 int *selectionStart, int *selectionLength) const override;
     void prepareSearch(const QString &entry) override;
 
diff --git a/src/plugins/cppeditor/cppcurrentdocumentfilter.cpp b/src/plugins/cppeditor/cppcurrentdocumentfilter.cpp
index a35eb9c6f14..7c83ceaec61 100644
--- a/src/plugins/cppeditor/cppcurrentdocumentfilter.cpp
+++ b/src/plugins/cppeditor/cppcurrentdocumentfilter.cpp
@@ -117,7 +117,7 @@ QList<Core::LocatorFilterEntry> CppCurrentDocumentFilter::matchesFor(
     return betterEntries;
 }
 
-void CppCurrentDocumentFilter::accept(Core::LocatorFilterEntry selection,
+void CppCurrentDocumentFilter::accept(const Core::LocatorFilterEntry &selection,
                                       QString *newText, int *selectionStart,
                                       int *selectionLength) const
 {
diff --git a/src/plugins/cppeditor/cppcurrentdocumentfilter.h b/src/plugins/cppeditor/cppcurrentdocumentfilter.h
index 073f601d374..b6c715c70db 100644
--- a/src/plugins/cppeditor/cppcurrentdocumentfilter.h
+++ b/src/plugins/cppeditor/cppcurrentdocumentfilter.h
@@ -47,7 +47,7 @@ public:
 
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/cppeditor/cpplocatorfilter.cpp b/src/plugins/cppeditor/cpplocatorfilter.cpp
index 1def7351788..08421e6cb9d 100644
--- a/src/plugins/cppeditor/cpplocatorfilter.cpp
+++ b/src/plugins/cppeditor/cpplocatorfilter.cpp
@@ -136,7 +136,7 @@ QList<Core::LocatorFilterEntry> CppLocatorFilter::matchesFor(
     return std::accumulate(std::begin(entries), std::end(entries), QList<Core::LocatorFilterEntry>());
 }
 
-void CppLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void CppLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                               QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/cppeditor/cpplocatorfilter.h b/src/plugins/cppeditor/cpplocatorfilter.h
index fa579f1067a..fd74f1a9f6a 100644
--- a/src/plugins/cppeditor/cpplocatorfilter.h
+++ b/src/plugins/cppeditor/cpplocatorfilter.h
@@ -43,7 +43,7 @@ public:
 
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 protected:
diff --git a/src/plugins/help/helpindexfilter.cpp b/src/plugins/help/helpindexfilter.cpp
index ee810c866e7..5e422c3a59d 100644
--- a/src/plugins/help/helpindexfilter.cpp
+++ b/src/plugins/help/helpindexfilter.cpp
@@ -197,7 +197,7 @@ QList<LocatorFilterEntry> HelpIndexFilter::matchesFor(QFutureInterface<LocatorFi
 
 #endif
 
-void HelpIndexFilter::accept(LocatorFilterEntry selection,
+void HelpIndexFilter::accept(const LocatorFilterEntry &selection,
                              QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/help/helpindexfilter.h b/src/plugins/help/helpindexfilter.h
index 910e19cd37b..fe8a3d89547 100644
--- a/src/plugins/help/helpindexfilter.h
+++ b/src/plugins/help/helpindexfilter.h
@@ -48,7 +48,7 @@ public:
     // ILocatorFilter
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
     void refresh(QFutureInterface<void> &future) override;
 
diff --git a/src/plugins/languageclient/locatorfilter.cpp b/src/plugins/languageclient/locatorfilter.cpp
index 28d01d2c82d..5ccc4d175a0 100644
--- a/src/plugins/languageclient/locatorfilter.cpp
+++ b/src/plugins/languageclient/locatorfilter.cpp
@@ -218,7 +218,7 @@ QList<Core::LocatorFilterEntry> DocumentLocatorFilter::matchesFor(
     return {};
 }
 
-void DocumentLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void DocumentLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                    QString * /*newText*/,
                                    int * /*selectionStart*/,
                                    int * /*selectionLength*/) const
@@ -325,7 +325,7 @@ QList<Core::LocatorFilterEntry> WorkspaceLocatorFilter::matchesFor(
         .toList();
 }
 
-void WorkspaceLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void WorkspaceLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                     QString * /*newText*/,
                                     int * /*selectionStart*/,
                                     int * /*selectionLength*/) const
diff --git a/src/plugins/languageclient/locatorfilter.h b/src/plugins/languageclient/locatorfilter.h
index ebc35de57a7..c149fadcad0 100644
--- a/src/plugins/languageclient/locatorfilter.h
+++ b/src/plugins/languageclient/locatorfilter.h
@@ -49,7 +49,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText,
                 int *selectionStart,
                 int *selectionLength) const override;
@@ -103,7 +103,7 @@ public:
     void prepareSearch(const QString &entry, const QVector<Client *> &clients);
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText,
                 int *selectionStart,
                 int *selectionLength) const override;
diff --git a/src/plugins/macros/macrolocatorfilter.cpp b/src/plugins/macros/macrolocatorfilter.cpp
index 35b238454b7..533f2461907 100644
--- a/src/plugins/macros/macrolocatorfilter.cpp
+++ b/src/plugins/macros/macrolocatorfilter.cpp
@@ -85,7 +85,7 @@ QList<Core::LocatorFilterEntry> MacroLocatorFilter::matchesFor(QFutureInterface<
     return betterEntries;
 }
 
-void MacroLocatorFilter::accept(Core::LocatorFilterEntry selection,
+void MacroLocatorFilter::accept(const Core::LocatorFilterEntry &selection,
                                 QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/macros/macrolocatorfilter.h b/src/plugins/macros/macrolocatorfilter.h
index b12a8a30ff4..f81831c3f8b 100644
--- a/src/plugins/macros/macrolocatorfilter.h
+++ b/src/plugins/macros/macrolocatorfilter.h
@@ -42,7 +42,7 @@ public:
 
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/qmljstools/qmljsfunctionfilter.cpp b/src/plugins/qmljstools/qmljsfunctionfilter.cpp
index 60b0cedc8c7..6525cff633a 100644
--- a/src/plugins/qmljstools/qmljsfunctionfilter.cpp
+++ b/src/plugins/qmljstools/qmljsfunctionfilter.cpp
@@ -95,7 +95,7 @@ QList<Core::LocatorFilterEntry> FunctionFilter::matchesFor(
     return std::accumulate(std::begin(entries), std::end(entries), QList<Core::LocatorFilterEntry>());
 }
 
-void FunctionFilter::accept(Core::LocatorFilterEntry selection,
+void FunctionFilter::accept(const Core::LocatorFilterEntry &selection,
                             QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/qmljstools/qmljsfunctionfilter.h b/src/plugins/qmljstools/qmljsfunctionfilter.h
index ee96834a5c1..d0997f54b96 100644
--- a/src/plugins/qmljstools/qmljsfunctionfilter.h
+++ b/src/plugins/qmljstools/qmljsfunctionfilter.h
@@ -42,7 +42,7 @@ public:
 
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private:
diff --git a/src/plugins/texteditor/linenumberfilter.cpp b/src/plugins/texteditor/linenumberfilter.cpp
index 7695bbd39d7..7b772023986 100644
--- a/src/plugins/texteditor/linenumberfilter.cpp
+++ b/src/plugins/texteditor/linenumberfilter.cpp
@@ -90,7 +90,7 @@ QList<LocatorFilterEntry> LineNumberFilter::matchesFor(QFutureInterface<LocatorF
     return value;
 }
 
-void LineNumberFilter::accept(LocatorFilterEntry selection,
+void LineNumberFilter::accept(const LocatorFilterEntry &selection,
                               QString *newText, int *selectionStart, int *selectionLength) const
 {
     Q_UNUSED(newText)
diff --git a/src/plugins/texteditor/linenumberfilter.h b/src/plugins/texteditor/linenumberfilter.h
index c730e9803c1..1c447516a19 100644
--- a/src/plugins/texteditor/linenumberfilter.h
+++ b/src/plugins/texteditor/linenumberfilter.h
@@ -46,7 +46,7 @@ public:
     void prepareSearch(const QString &entry) override;
     QList<Core::LocatorFilterEntry> matchesFor(QFutureInterface<Core::LocatorFilterEntry> &future,
                                                const QString &entry) override;
-    void accept(Core::LocatorFilterEntry selection,
+    void accept(const Core::LocatorFilterEntry &selection,
                 QString *newText, int *selectionStart, int *selectionLength) const override;
 
 private: