feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Maemo: Fix issue with cached device configuration.

Browse Source 
External functions need to access the real device config,
internal ones need the cached one during deployment.

Task-number: QTCREATORBUG-4514
This commit is contained in:
Christian Kandeler
2011-04-21 10:53:25 +02:00
parent 4c65bac230
commit 2781453b94
4 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qt4projectmanager/qt-maemo/abstractmaemodeploystep.cpp
View File

@@ -395,10 +395,13 @@ void AbstractMaemoDeployStep::handleRemoteStderr(const QString &output)
}
MaemoPortList AbstractMaemoDeployStep::freePorts() const
{
return freePorts(m_deviceConfig);
}
MaemoPortList AbstractMaemoDeployStep::freePorts(const MaemoDeviceConfig::ConstPtr &devConf) const
{
const Qt4BuildConfiguration * const qt4bc = qt4BuildConfiguration();
const MaemoDeviceConfig::ConstPtr &devConf
= m_cachedDeviceConfig ? m_cachedDeviceConfig : m_deviceConfig;
if (!devConf)
return MaemoPortList();
if (devConf->type() == MaemoDeviceConfig::Emulator && qt4bc) {

2
src/plugins/qt4projectmanager/qt-maemo/abstractmaemodeploystep.h
View File

@@ -97,7 +97,9 @@ protected:
QString deployMountPoint() const;
const Qt4BuildConfiguration *qt4BuildConfiguration() const;
MaemoPortList freePorts(const QSharedPointer<const MaemoDeviceConfig> &devConfig) const;
QSharedPointer<Utils::SshConnection> connection() const { return m_connection; }
QSharedPointer<const MaemoDeviceConfig> cachedDeviceConfig() const { return m_cachedDeviceConfig; }
private slots:
void start();

4
src/plugins/qt4projectmanager/qt-maemo/maemodeploybymountstep.cpp
View File

@@ -153,8 +153,8 @@ void AbstractMaemoDeployByMountStep::handleMountDebugOutput(const QString &outpu
void AbstractMaemoDeployByMountStep::mount()
{
m_extendedState = Mounting;
m_mounter->setupMounts(connection(), mountSpecifications(), freePorts(),
qt4BuildConfiguration());
m_mounter->setupMounts(connection(), mountSpecifications(),
freePorts(cachedDeviceConfig()), qt4BuildConfiguration());
}
QString AbstractMaemoDeployByMountStep::deployMountPoint() const

2
src/plugins/qt4projectmanager/qt-maemo/maemodirectdeviceuploadstep.cpp
View File

@@ -153,7 +153,7 @@ void MaemoDirectDeviceUploadStep::handleMkdirFinished(int exitStatus)
raiseError(tr("Failed to upload file '%1'.").arg(nativePath));
setFinished();
} else if (fi.isDir()) {
setDeployed(deviceConfig()->sshParameters().host, d);
setDeployed(cachedDeviceConfig()->sshParameters().host, d);
m_filesToUpload.removeFirst();
uploadNextFile();
} else {