feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsCommand: Simplify public runCommand()

Browse Source 
Get rid of unused workingDirectory (default working
directory will be used) and exitCodeInterpreter.
Simplify internals a bit.

Change-Id: I2a7547e5a594dd7a21f390daeb06778656e9e971
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-08-02 17:28:15 +02:00
parent b2f0f78bdc
commit 278d297397
7 changed files with 36 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/vcsbase/vcsbaseclient.cpp
View File

@@ -170,7 +170,7 @@ CommandResult VcsBaseClientImpl::vcsFullySynchronousExec(const FilePath &working
command.addFlags(flags);
if (codec)
command.setCodec(codec);
return command.runCommand(cmdLine, workingDir, timeoutS > 0 ? timeoutS : vcsTimeoutS());
return command.runCommand(cmdLine, timeoutS > 0 ? timeoutS : vcsTimeoutS());
}
void VcsBaseClientImpl::resetCachedVcsInfo(const FilePath &workingDir)
@@ -214,7 +214,7 @@ CommandResult VcsBaseClientImpl::vcsSynchronousExec(const FilePath &workingDir,
VcsCommand command(workingDir, env.isValid() ? env : Environment::systemEnvironment());
command.addFlags(flags);
command.setCodec(outputCodec);
return command.runCommand({vcsBinary(), args}, workingDir, vcsTimeoutS());
return command.runCommand({vcsBinary(), args}, vcsTimeoutS());
}
int VcsBaseClientImpl::vcsTimeoutS() const