From 27d4f4b6631f2310a47c3681107680b22fccb0b0 Mon Sep 17 00:00:00 2001 From: Aleksei German Date: Mon, 22 Jun 2020 11:45:14 +0200 Subject: [PATCH] QmlDesigner: Fix crashes in connection view - Fix for connections order in view - Fix for binding and connection editor init crash Change-Id: If0faf401b8e89a5548c65f07284138e869612c95 Reviewed-by: Thomas Hartmann --- .../components/bindingeditor/bindingeditorwidget.cpp | 1 + .../components/connectioneditor/connectionmodel.cpp | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/qmldesigner/components/bindingeditor/bindingeditorwidget.cpp b/src/plugins/qmldesigner/components/bindingeditor/bindingeditorwidget.cpp index 51c384e1d55..91ffa990c4e 100644 --- a/src/plugins/qmldesigner/components/bindingeditor/bindingeditorwidget.cpp +++ b/src/plugins/qmldesigner/components/bindingeditor/bindingeditorwidget.cpp @@ -134,6 +134,7 @@ BindingEditorFactory::BindingEditorFactory() { setId(BINDINGEDITOR_CONTEXT_ID); setDisplayName(QCoreApplication::translate("OpenWith::Editors", QmlDesigner::BINDINGEDITOR_CONTEXT_ID)); + setEditorActionHandlers(0); setDocumentCreator([]() { return new BindingDocument; }); setEditorWidgetCreator([]() { return new BindingEditorWidget; }); diff --git a/src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp b/src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp index f4fa65e52de..36444db228a 100644 --- a/src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp +++ b/src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp @@ -219,9 +219,6 @@ void ConnectionModel::updateTargetNode(int rowNumber) connectionNode.bindingProperty("target").setExpression(newTarget); }); - QStandardItem* idItem = item(rowNumber, 0); - updateCustomData(idItem, signalHandlerProperty); - } else { qWarning() << "BindingModel::updatePropertyName invalid target id"; }