feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Further robustify QmlInspectorAgent

Browse Source 
When (re-)querying the root contexts, make sure we clear the old queries
first. One of the QML engines in the target may have created an object,
causing the contexts to be re-queried while queries for other engines
are still running. This would cause mismatches between the m_engines and
m_rootContextQueryIds arrays. In turn, in onResult() we would access an
invalid index in the m_engines array. Furthermore, make the assert that
guards against such an invalid access a QTC_GUARD and log the pending
queries before they are cleared.

When the target replies to the now-invalid root context queries we will
end up in the default branch of onResult,
m_qmlEngine->expressionEvaluated(), and that one silently ignores
unknown query IDs.

Task-number: QTCREATORBUG-22654
Change-Id: I1fe4751ea3592eb26c494696bea3d84fa3e62617
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Ulf Hermann
2019-12-02 11:10:45 +01:00
parent e69f8f2048
commit 2808f633ec
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/debugger/qml/qmlinspectoragent.cpp
View File

@@ -262,8 +262,7 @@ void QmlInspectorAgent::onResult(quint32 queryId, const QVariant &value,
if (index < 0) { if (index < 0) {
if (QTC_GUARD(m_qmlEngine)) if (QTC_GUARD(m_qmlEngine))
m_qmlEngine->expressionEvaluated(queryId, value); m_qmlEngine->expressionEvaluated(queryId, value);
} else { } else if (QTC_GUARD(index < m_engines.length())) {
Q_ASSERT(index < m_engines.length());
const int engineId = m_engines.at(index).debugId(); const int engineId = m_engines.at(index).debugId();
m_rootContexts.insert(engineId, qvariant_cast<ContextReference>(value)); m_rootContexts.insert(engineId, qvariant_cast<ContextReference>(value));
if (m_rootContexts.size() == m_engines.size()) { if (m_rootContexts.size() == m_engines.size()) {
@@ -373,7 +372,7 @@ void QmlInspectorAgent::reloadEngines()
void QmlInspectorAgent::queryEngineContext() void QmlInspectorAgent::queryEngineContext()
{ {
qCDebug(qmlInspectorLog) << __FUNCTION__; qCDebug(qmlInspectorLog) << __FUNCTION__ << "pending queries:" << m_rootContextQueryIds;
if (!isConnected() || !boolSetting(ShowQmlObjectTree)) if (!isConnected() || !boolSetting(ShowQmlObjectTree))
return; return;
@@ -381,6 +380,7 @@ void QmlInspectorAgent::queryEngineContext()
log(LogSend, "LIST_OBJECTS"); log(LogSend, "LIST_OBJECTS");
m_rootContexts.clear(); m_rootContexts.clear();
m_rootContextQueryIds.clear();
for (const auto &engine : qAsConst(m_engines)) for (const auto &engine : qAsConst(m_engines))
m_rootContextQueryIds.append(m_engineClient->queryRootContexts(engine)); m_rootContextQueryIds.append(m_engineClient->queryRootContexts(engine));
} }