From 28334638ab44f1b86c8eb0f9f64e7e9d3c441e04 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Tue, 4 Jan 2022 08:55:52 +0200 Subject: [PATCH] Debugger: Fix MSVC warning warning: C4305: '/=': truncation from 'int' to 'IntType' with q[u]int8 template argument. Change-Id: I0f0063191b0e51ab79f94073ead65da86ea82440 Reviewed-by: hjk --- src/plugins/debugger/watchhandler.cpp | 33 ++++++++++++--------------- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/src/plugins/debugger/watchhandler.cpp b/src/plugins/debugger/watchhandler.cpp index 6d8561cc21a..6c9d7db78bf 100644 --- a/src/plugins/debugger/watchhandler.cpp +++ b/src/plugins/debugger/watchhandler.cpp @@ -624,7 +624,7 @@ template QString reformatInteger(IntType value, int format) QString res = "\""; while (value > 0) { res = QChar(ushort(value & 255)) + res; - value /= 256; + value >>= 8; } return "\"" + res; } @@ -639,26 +639,21 @@ static QString reformatInteger(quint64 value, int format, int size, bool isSigne isSigned = false; switch (size) { - case 1: - value = value & 0xff; - return isSigned - ? reformatInteger(value, format) - : reformatInteger(value, format); - case 2: - value = value & 0xffff; - return isSigned - ? reformatInteger(value, format) - : reformatInteger(value, format); - case 4: - value = value & 0xffffffff; - return isSigned - ? reformatInteger(value, format) - : reformatInteger(value, format); - default: - case 8: return isSigned + case 1: + value = value & 0xff; + break; + case 2: + value = value & 0xffff; + break; + case 4: + value = value & 0xffffffff; + break; + default: + break; + } + return isSigned ? reformatInteger(value, format) : reformatInteger(value, format); - } } // Format printable (char-type) characters