feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Nim: Aspectify NimSettings

Browse Source 
Change-Id: I3954bec762fb3f5d3426663108ff493f140f1b5e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
This commit is contained in:
hjk
2021-03-25 15:45:58 +01:00
parent f48586b8d8
commit 283ef97384
10 changed files with 61 additions and 301 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/nim/nimplugin.cpp
View File

@@ -41,7 +41,6 @@
#include "project/nimbletaskstep.h"
#include "settings/nimcodestylepreferencesfactory.h"
#include "settings/nimcodestylesettingspage.h"
#include "settings/nimtoolssettingspage.h"
#include "settings/nimsettings.h"
#include "suggest/nimsuggestcache.h"
@@ -61,10 +60,9 @@ class NimPluginPrivate
{
public:
NimPluginPrivate()
: toolsSettingsPage(&settings)
{
Suggest::NimSuggestCache::instance().setExecutablePath(settings.nimSuggestPath());
QObject::connect(&settings, &NimSettings::nimSuggestPathChanged,
Suggest::NimSuggestCache::instance().setExecutablePath(settings.nimSuggestPath.value());
QObject::connect(&settings.nimSuggestPath, &StringAspect::valueChanged,
&Suggest::NimSuggestCache::instance(),
&Suggest::NimSuggestCache::setExecutablePath);
}
@@ -96,7 +94,7 @@ public:
NimCompilerBuildStepFactory buildStepFactory;
NimCompilerCleanStepFactory cleanStepFactory;
NimCodeStyleSettingsPage codeStyleSettingsPage;
NimToolsSettingsPage toolsSettingsPage;
NimToolsSettingsPage toolsSettingsPage{&settings};
NimCodeStylePreferencesFactory codeStylePreferencesPage;
NimToolChainFactory toolChainFactory;
};