From 2845d758499648bc4c50e25def1e497b3e0c293c Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 30 May 2016 14:05:33 +0200 Subject: [PATCH] Debugger: Remove AnalyzerRunControl::pause etc Only supported by CallGrind, and still functional there. This interface might be useful to move to the ProjectExplorer::RunControl base class, as similar functionality is present e.g. in the QmlProfiler. Change-Id: Ie1f8a044ace77aea7ed3c1296847cc7497bac409 Reviewed-by: Christian Stenger --- src/plugins/debugger/analyzer/analyzerruncontrol.h | 5 ----- src/plugins/valgrind/callgrindengine.h | 6 ++---- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/plugins/debugger/analyzer/analyzerruncontrol.h b/src/plugins/debugger/analyzer/analyzerruncontrol.h index bc4ac266ebb..7c565fa4268 100644 --- a/src/plugins/debugger/analyzer/analyzerruncontrol.h +++ b/src/plugins/debugger/analyzer/analyzerruncontrol.h @@ -47,11 +47,6 @@ class DEBUGGER_EXPORT AnalyzerRunControl : public ProjectExplorer::RunControl public: AnalyzerRunControl(ProjectExplorer::RunConfiguration *runConfiguration, Core::Id runMode); - /// Controller actions. - virtual bool canPause() const { return false; } - virtual void pause() {} - virtual void unpause() {} - virtual void notifyRemoteSetupDone(Utils::Port) {} virtual void notifyRemoteFinished() {} diff --git a/src/plugins/valgrind/callgrindengine.h b/src/plugins/valgrind/callgrindengine.h index 8e30b357cbb..a9aa3ab47a3 100644 --- a/src/plugins/valgrind/callgrindengine.h +++ b/src/plugins/valgrind/callgrindengine.h @@ -44,14 +44,12 @@ public: Valgrind::Callgrind::ParseData *takeParserData(); - bool canPause() const override { return true; } - public slots: /// controller actions void dump(); void reset(); - void pause() override; - void unpause() override; + void pause(); + void unpause(); /// marks the callgrind process as paused /// calls pause() and unpause() if there's an active run