feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Merge CppTools into CppEditor

Browse Source 
There was no proper separation of responsibilities between these
plugins. In particular, CppTools had lots of editor-related
functionality, so it's not clear why it was separated out in the first
place.
In fact, for a lot of code, it seemed quite arbitrary where it was put
(just one example: switchHeaderSource() was in CppTools, wheras
switchDeclarationDefinition() was in CppEditor).
Merging the plugins will enable us to get rid of various convoluted
pseudo-abstractions that were only introduced to keep up the artificial
separation.

Change-Id: Iafc3bce625b4794f6d4aa03df6cddc7f2d26716a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2021-08-30 10:58:08 +02:00
parent 3e1fa0f170
commit 284817fae6
525 changed files with 3705 additions and 4179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/clangtools/clangtoolsutils.cpp
View File

@@ -31,8 +31,8 @@
#include "clangtoolssettings.h"
#include <coreplugin/icore.h>
#include <cpptools/cpptoolsconstants.h>
#include <cpptools/cpptoolsreuse.h>
#include <cppeditor/cppeditorconstants.h>
#include <cppeditor/cpptoolsreuse.h>
#include <projectexplorer/projectexplorerconstants.h>
#include <utils/checkablemessagebox.h>
@@ -41,9 +41,9 @@
#include <utils/hostosinfo.h>
#include <utils/qtcprocess.h>
#include <cpptools/clangdiagnosticconfigsmodel.h>
#include <cppeditor/clangdiagnosticconfigsmodel.h>
using namespace CppTools;
using namespace CppEditor;
using namespace Utils;
namespace ClangTools {
@@ -293,7 +293,7 @@ QString documentationUrl(const QString &checkName)
name = checkName.mid(clazyPrefix.length());
url = clazyDocUrl(name);
} else if (name.startsWith(clangStaticAnalyzerPrefix)) {
url = CppTools::Constants::CLANG_STATIC_ANALYZER_DOCUMENTATION_URL;
url = CppEditor::Constants::CLANG_STATIC_ANALYZER_DOCUMENTATION_URL;
} else {
url = clangTidyDocUrl(name);
}