feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DiffEditor: Replace QSharedPointer with std::shared_ptr

Browse Source 
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.

Change-Id: I8364f20fddca43c22d47ba8df07a06a176950695
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2024-02-01 15:03:13 +01:00
parent b1aec1b356
commit 2853237fd0
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/diffeditor/diffeditor.h
View File

@@ -43,7 +43,7 @@ public:
private:
DiffEditor();
void setDocument(QSharedPointer<DiffEditorDocument> doc);
void setDocument(std::shared_ptr<DiffEditorDocument> doc);
void documentHasChanged();
void toggleDescription();
@@ -69,7 +69,7 @@ private:
IDiffView *nextView();
void setupView(IDiffView *view);
QSharedPointer<DiffEditorDocument> m_document;
std::shared_ptr<DiffEditorDocument> m_document;
DescriptionEditorWidget *m_descriptionWidget = nullptr;
UnifiedView *m_unifiedView = nullptr;
SideBySideView *m_sideBySideView = nullptr;