From 285f054d74dc31b22576cf43eb77a75b4f3002f2 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Thu, 31 Aug 2017 14:05:28 +0200 Subject: [PATCH] Locator: Don't ask disabled filters for results If they are disabled, behave is if they didn't exist (when looking for matches). This was no issue with our own filters so far, because these (by accident) also don't have anything to return if they are disabled. Change-Id: Ia5fe85039631c41f7488d78d9f54b6322dc72b32 Reviewed-by: Tobias Hunger --- src/plugins/coreplugin/locator/locatorwidget.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/coreplugin/locator/locatorwidget.cpp b/src/plugins/coreplugin/locator/locatorwidget.cpp index 6d3af5890a5..9dbcde15f40 100644 --- a/src/plugins/coreplugin/locator/locatorwidget.cpp +++ b/src/plugins/coreplugin/locator/locatorwidget.cpp @@ -746,7 +746,8 @@ QList LocatorWidget::filtersFor(const QString &text, QString & break; } const int whiteSpace = text.indexOf(QChar::Space, firstNonSpace); - const QList filters = Locator::filters(); + const QList filters = Utils::filtered(Locator::filters(), + &ILocatorFilter::isEnabled); if (whiteSpace >= 0) { const QString prefix = text.mid(firstNonSpace, whiteSpace - firstNonSpace).toLower(); QList prefixFilters;