From 288b43424a0d292497cc1a9ae9cfa9f6cf5cb538 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Fri, 10 Feb 2023 23:37:49 +0100
Subject: [PATCH] Remove unneeded includes of task.h and taskhub.h

And some other includes spotted by the way.

Change-Id: Icd5eadf16617506fe48fae52ff0639d247002d75
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
---
 .../compilationdbparser.cpp                                 | 1 -
 src/plugins/debugger/debuggerengine.cpp                     | 1 -
 src/plugins/genericprojectmanager/genericprojectplugin.cpp  | 1 -
 src/plugins/mesonprojectmanager/ninjaparser.h               | 1 -
 src/plugins/mesonprojectmanager/tests/testmesonparser.cpp   | 2 --
 src/plugins/projectexplorer/clangparser.h                   | 1 -
 src/plugins/projectexplorer/compileoutputwindow.cpp         | 6 +++---
 src/plugins/projectexplorer/configtaskhandler.cpp           | 3 ---
 src/plugins/projectexplorer/gccparser.cpp                   | 2 --
 src/plugins/projectexplorer/gnumakeparser.cpp               | 2 --
 src/plugins/projectexplorer/kitmanager.cpp                  | 3 ---
 src/plugins/projectexplorer/osparser.h                      | 2 --
 src/plugins/projectexplorer/targetsetuppage.h               | 4 +---
 src/plugins/projectexplorer/xcodebuildparser.cpp            | 1 -
 src/plugins/qbsprojectmanager/qbsprofilessettingspage.cpp   | 2 --
 src/plugins/qbsprojectmanager/qbsproject.h                  | 1 -
 src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp        | 1 -
 src/plugins/qmlprofiler/qmlprofilertool.cpp                 | 1 -
 18 files changed, 4 insertions(+), 31 deletions(-)

diff --git a/src/plugins/compilationdatabaseprojectmanager/compilationdbparser.cpp b/src/plugins/compilationdatabaseprojectmanager/compilationdbparser.cpp
index 27c7477abc9..251e9685c45 100644
--- a/src/plugins/compilationdatabaseprojectmanager/compilationdbparser.cpp
+++ b/src/plugins/compilationdatabaseprojectmanager/compilationdbparser.cpp
@@ -7,7 +7,6 @@
 #include "compilationdatabaseprojectmanagertr.h"
 
 #include <coreplugin/progressmanager/progressmanager.h>
-#include <projectexplorer/task.h>
 #include <projectexplorer/treescanner.h>
 #include <utils/mimeutils.h>
 #include <utils/runextensions.h>
diff --git a/src/plugins/debugger/debuggerengine.cpp b/src/plugins/debugger/debuggerengine.cpp
index f9d6cfa005a..14cab127508 100644
--- a/src/plugins/debugger/debuggerengine.cpp
+++ b/src/plugins/debugger/debuggerengine.cpp
@@ -45,7 +45,6 @@
 
 #include <projectexplorer/devicesupport/devicemanager.h>
 #include <projectexplorer/projectexplorer.h>
-#include <projectexplorer/taskhub.h>
 
 #include <texteditor/texteditor.h>
 #include <texteditor/texteditorsettings.h>
diff --git a/src/plugins/genericprojectmanager/genericprojectplugin.cpp b/src/plugins/genericprojectmanager/genericprojectplugin.cpp
index de49bd4d802..8999016c2aa 100644
--- a/src/plugins/genericprojectmanager/genericprojectplugin.cpp
+++ b/src/plugins/genericprojectmanager/genericprojectplugin.cpp
@@ -21,7 +21,6 @@
 #include <projectexplorer/projectnodes.h>
 #include <projectexplorer/projecttree.h>
 #include <projectexplorer/selectablefilesmodel.h>
-#include <projectexplorer/taskhub.h>
 
 #include <utils/algorithm.h>
 #include <utils/fileutils.h>
diff --git a/src/plugins/mesonprojectmanager/ninjaparser.h b/src/plugins/mesonprojectmanager/ninjaparser.h
index ff47a80c856..6236549ed75 100644
--- a/src/plugins/mesonprojectmanager/ninjaparser.h
+++ b/src/plugins/mesonprojectmanager/ninjaparser.h
@@ -4,7 +4,6 @@
 #pragma once
 
 #include <projectexplorer/ioutputparser.h>
-#include <projectexplorer/task.h>
 
 #include <QRegularExpression>
 
diff --git a/src/plugins/mesonprojectmanager/tests/testmesonparser.cpp b/src/plugins/mesonprojectmanager/tests/testmesonparser.cpp
index 5134709f354..08bd19468ec 100644
--- a/src/plugins/mesonprojectmanager/tests/testmesonparser.cpp
+++ b/src/plugins/mesonprojectmanager/tests/testmesonparser.cpp
@@ -3,8 +3,6 @@
 
 #include "../mesonoutputparser.h"
 
-#include <projectexplorer/taskhub.h>
-
 #include <utils/fileinprojectfinder.h>
 #include <utils/theme/theme.h>
 #include <utils/theme/theme_p.h>
diff --git a/src/plugins/projectexplorer/clangparser.h b/src/plugins/projectexplorer/clangparser.h
index 9f97d3ae641..8918bcb8213 100644
--- a/src/plugins/projectexplorer/clangparser.h
+++ b/src/plugins/projectexplorer/clangparser.h
@@ -4,7 +4,6 @@
 #pragma once
 
 #include "gccparser.h"
-#include "task.h"
 
 #include <QRegularExpression>
 
diff --git a/src/plugins/projectexplorer/compileoutputwindow.cpp b/src/plugins/projectexplorer/compileoutputwindow.cpp
index e6a4c9abd3e..55680befb6c 100644
--- a/src/plugins/projectexplorer/compileoutputwindow.cpp
+++ b/src/plugins/projectexplorer/compileoutputwindow.cpp
@@ -4,14 +4,11 @@
 #include "compileoutputwindow.h"
 
 #include "buildmanager.h"
-#include "ioutputparser.h"
-#include "projectexplorer.h"
 #include "projectexplorerconstants.h"
 #include "projectexplorericons.h"
 #include "projectexplorersettings.h"
 #include "projectexplorertr.h"
 #include "showoutputtaskhandler.h"
-#include "task.h"
 
 #include <coreplugin/outputwindow.h>
 #include <coreplugin/icore.h>
@@ -39,6 +36,9 @@
 #include <QVBoxLayout>
 
 namespace ProjectExplorer {
+
+class Task;
+
 namespace Internal {
 
 const char SETTINGS_KEY[] = "ProjectExplorer/CompileOutput/Zoom";
diff --git a/src/plugins/projectexplorer/configtaskhandler.cpp b/src/plugins/projectexplorer/configtaskhandler.cpp
index 9672c96d10a..04d0ca1f3a7 100644
--- a/src/plugins/projectexplorer/configtaskhandler.cpp
+++ b/src/plugins/projectexplorer/configtaskhandler.cpp
@@ -3,9 +3,6 @@
 
 #include "configtaskhandler.h"
 
-#include "task.h"
-#include "taskhub.h"
-
 #include <coreplugin/icore.h>
 
 #include <QAction>
diff --git a/src/plugins/projectexplorer/gccparser.cpp b/src/plugins/projectexplorer/gccparser.cpp
index 97f7a1361eb..f3c457f90f9 100644
--- a/src/plugins/projectexplorer/gccparser.cpp
+++ b/src/plugins/projectexplorer/gccparser.cpp
@@ -5,8 +5,6 @@
 #include "ldparser.h"
 #include "lldparser.h"
 #include "task.h"
-#include "projectexplorerconstants.h"
-#include "buildmanager.h"
 
 #include <utils/qtcassert.h>
 
diff --git a/src/plugins/projectexplorer/gnumakeparser.cpp b/src/plugins/projectexplorer/gnumakeparser.cpp
index 58b606d0201..a1937df384f 100644
--- a/src/plugins/projectexplorer/gnumakeparser.cpp
+++ b/src/plugins/projectexplorer/gnumakeparser.cpp
@@ -3,7 +3,6 @@
 
 #include "gnumakeparser.h"
 
-#include "projectexplorerconstants.h"
 #include "task.h"
 
 #include <utils/qtcassert.h>
@@ -136,7 +135,6 @@ bool GnuMakeParser::hasFatalErrors() const
 
 #   include "outputparser_test.h"
 #   include "projectexplorer.h"
-#   include "projectexplorerconstants.h"
 
 namespace ProjectExplorer {
 
diff --git a/src/plugins/projectexplorer/kitmanager.cpp b/src/plugins/projectexplorer/kitmanager.cpp
index 5aafe5831c1..cb67e11fac0 100644
--- a/src/plugins/projectexplorer/kitmanager.cpp
+++ b/src/plugins/projectexplorer/kitmanager.cpp
@@ -8,11 +8,8 @@
 #include "kit.h"
 #include "kitfeatureprovider.h"
 #include "kitinformation.h"
-#include "kitmanagerconfigwidget.h"
-#include "project.h"
 #include "projectexplorerconstants.h"
 #include "projectexplorertr.h"
-#include "task.h"
 #include "toolchainmanager.h"
 
 #include <coreplugin/icore.h>
diff --git a/src/plugins/projectexplorer/osparser.h b/src/plugins/projectexplorer/osparser.h
index 4811233e689..6fb9a0ff942 100644
--- a/src/plugins/projectexplorer/osparser.h
+++ b/src/plugins/projectexplorer/osparser.h
@@ -5,8 +5,6 @@
 
 #include "ioutputparser.h"
 
-#include <projectexplorer/task.h>
-
 namespace ProjectExplorer {
 
 class PROJECTEXPLORER_EXPORT OsParser : public ProjectExplorer::OutputTaskParser
diff --git a/src/plugins/projectexplorer/targetsetuppage.h b/src/plugins/projectexplorer/targetsetuppage.h
index 2adfc047ea5..99448693c6f 100644
--- a/src/plugins/projectexplorer/targetsetuppage.h
+++ b/src/plugins/projectexplorer/targetsetuppage.h
@@ -5,10 +5,8 @@
 
 #include "projectexplorer_export.h"
 
-#include "kitinformation.h"
-#include "kitmanager.h"
+#include "kit.h"
 #include "projectimporter.h"
-#include "task.h"
 
 #include <utils/wizardpage.h>
 
diff --git a/src/plugins/projectexplorer/xcodebuildparser.cpp b/src/plugins/projectexplorer/xcodebuildparser.cpp
index 8bb08ce2cc0..4dd55302341 100644
--- a/src/plugins/projectexplorer/xcodebuildparser.cpp
+++ b/src/plugins/projectexplorer/xcodebuildparser.cpp
@@ -3,7 +3,6 @@
 
 #include "xcodebuildparser.h"
 
-#include "projectexplorerconstants.h"
 #include "projectexplorertr.h"
 #include "task.h"
 
diff --git a/src/plugins/qbsprojectmanager/qbsprofilessettingspage.cpp b/src/plugins/qbsprojectmanager/qbsprofilessettingspage.cpp
index 7cee7c6d2da..64c73ed5f0e 100644
--- a/src/plugins/qbsprojectmanager/qbsprofilessettingspage.cpp
+++ b/src/plugins/qbsprojectmanager/qbsprofilessettingspage.cpp
@@ -6,14 +6,12 @@
 #include "qbsprofilemanager.h"
 #include "qbsprojectmanagerconstants.h"
 #include "qbsprojectmanagertr.h"
-#include "qbssettings.h"
 
 #include <coreplugin/icore.h>
 #include <projectexplorer/kit.h>
 #include <projectexplorer/kitmanager.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/projectexplorericons.h>
-#include <projectexplorer/taskhub.h>
 #include <utils/algorithm.h>
 #include <utils/layoutbuilder.h>
 #include <utils/qtcassert.h>
diff --git a/src/plugins/qbsprojectmanager/qbsproject.h b/src/plugins/qbsprojectmanager/qbsproject.h
index ab4728ae749..048971db7ca 100644
--- a/src/plugins/qbsprojectmanager/qbsproject.h
+++ b/src/plugins/qbsprojectmanager/qbsproject.h
@@ -10,7 +10,6 @@
 #include <projectexplorer/extracompiler.h>
 #include <projectexplorer/project.h>
 #include <projectexplorer/projectnodes.h>
-#include <projectexplorer/task.h>
 
 #include <utils/environment.h>
 #include <utils/id.h>
diff --git a/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp b/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
index 14fecd00d93..e15fadb46db 100644
--- a/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
+++ b/src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
@@ -21,7 +21,6 @@
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
-#include <projectexplorer/taskhub.h>
 
 #include <qtsupport/profilereader.h>
 
diff --git a/src/plugins/qmlprofiler/qmlprofilertool.cpp b/src/plugins/qmlprofiler/qmlprofilertool.cpp
index ccea82819de..579a870a4b0 100644
--- a/src/plugins/qmlprofiler/qmlprofilertool.cpp
+++ b/src/plugins/qmlprofiler/qmlprofilertool.cpp
@@ -41,7 +41,6 @@
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/target.h>
 #include <projectexplorer/session.h>
-#include <projectexplorer/taskhub.h>
 
 #include <qtsupport/qtkitinformation.h>