feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Simplify data structures

Browse Source 
Do some cleanup.

Change-Id: If40fefbdb646f0eb434539f8306421a40e47a3ee
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-10-06 19:34:47 +02:00
parent 7ffdada4a3
commit 28c507eccb
15 changed files with 82 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
plugins/fossil/fossilcommitwidget.cpp
View File

@@ -33,11 +33,9 @@
#include <utils/completingtextedit.h>
#include <utils/qtcassert.h>
#include <QSyntaxHighlighter>
#include <QTextEdit>
#include <QRegularExpression>
#include <QDir>
#include <QRegularExpression>
#include <QSyntaxHighlighter>
namespace Fossil {
namespace Internal {
@@ -101,7 +99,7 @@ void FossilCommitWidget::setFields(const QString &repoPath, const BranchInfo &br
const QStringList &tags, const QString &userName)
{
m_commitPanelUi.localRootLineEdit->setText(QDir::toNativeSeparators(repoPath));
m_commitPanelUi.currentBranchLineEdit->setText(branch.name());
m_commitPanelUi.currentBranchLineEdit->setText(branch.name);
const QString tagsText = tags.join(", ");
m_commitPanelUi.currentTagsLineEdit->setText(tagsText);
m_commitPanelUi.authorLineEdit->setText(userName);
@@ -111,29 +109,21 @@ void FossilCommitWidget::setFields(const QString &repoPath, const BranchInfo &br
QString FossilCommitWidget::newBranch() const
{
const QString branchName = m_commitPanelUi.branchLineEdit->text().trimmed();
return branchName;
return m_commitPanelUi.branchLineEdit->text().trimmed();
}
QStringList FossilCommitWidget::tags() const
{
QString tagsText = m_commitPanelUi.tagsLineEdit->text().trimmed();
if (tagsText.isEmpty())
return QStringList();
return {};
tagsText.replace(',', ' ');
const QStringList tags = tagsText.split(' ', Qt::SkipEmptyParts);
return tags;
return tagsText.replace(',', ' ').split(' ', Qt::SkipEmptyParts);
}
QString FossilCommitWidget::committer() const
{
const QString author = m_commitPanelUi.authorLineEdit->text();
if (author.isEmpty())
return QString();
const QString user = author;
return user;
return m_commitPanelUi.authorLineEdit->text();
}
bool FossilCommitWidget::isPrivateOptionEnabled() const