feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Perforce: Use more direct check for executable presence

Browse Source 
The !isEmpty check is actually redundant, but currently cheaper than the
diversion through FilePath::fileAccess().

Change-Id: I44e6ec128c78cccf57c7276da70577a87b8c2f96
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2023-07-10 12:52:21 +02:00
parent 5f9408ee8d
commit 28e9591052
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/perforce/perforceplugin.cpp
View File

@@ -1117,11 +1117,8 @@ bool PerforcePluginPrivate::isVcsFileOrDirectory(const FilePath &filePath) const
bool PerforcePluginPrivate::isConfigured() const bool PerforcePluginPrivate::isConfigured() const
{ {
const QString binary = m_settings.p4BinaryPath.value(); const FilePath binary = m_settings.p4BinaryPath();
if (binary.isEmpty()) return !binary.isEmpty() && binary.isExecutableFile();
return false;
QFileInfo fi(binary);
return fi.exists() && fi.isFile() && fi.isExecutable();
} }
bool PerforcePluginPrivate::supportsOperation(Operation operation) const bool PerforcePluginPrivate::supportsOperation(Operation operation) const