From 297ff3b9b1106b763bc40e5b2e99878a7dada2f5 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 30 Jun 2023 16:00:53 +0200 Subject: [PATCH] AndroidRunnerWorker: Remove no-op code Since there is no call to recordData() with ANDROID_PRESTARTSHELLCMDLIST or with ANDROID_POSTFINISHSHELLCMDLIST, the recordedData() will always return empty variant. Change-Id: I2d96ddee12181c614a0282f5103fba3fc06b6486 Reviewed-by: Alessandro Portale --- src/plugins/android/androidrunnerworker.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/plugins/android/androidrunnerworker.cpp b/src/plugins/android/androidrunnerworker.cpp index c50129aac25..96b79989f39 100644 --- a/src/plugins/android/androidrunnerworker.cpp +++ b/src/plugins/android/androidrunnerworker.cpp @@ -277,9 +277,6 @@ AndroidRunnerWorker::AndroidRunnerWorker(RunWorker *runner, const QString &packa for (const QString &shellCmd : commands) m_beforeStartAdbCommands.append(QString("shell %1").arg(shellCmd)); } - const auto preStartCmdList = runner->recordedData(Constants::ANDROID_PRESTARTSHELLCMDLIST); - for (const QString &shellCmd : preStartCmdList.toStringList()) - m_beforeStartAdbCommands.append(QString("shell %1").arg(shellCmd)); if (const QVariantMap sd = runControl->settingsData(Constants::ANDROID_POSTFINISHSHELLCMDLIST); !sd.values().isEmpty()) { @@ -288,9 +285,6 @@ AndroidRunnerWorker::AndroidRunnerWorker(RunWorker *runner, const QString &packa for (const QString &shellCmd : commands) m_afterFinishAdbCommands.append(QString("shell %1").arg(shellCmd)); } - const auto postFinishCmdList = runner->recordedData(Constants::ANDROID_POSTFINISHSHELLCMDLIST); - for (const QString &shellCmd : postFinishCmdList.toStringList()) - m_afterFinishAdbCommands.append(QString("shell %1").arg(shellCmd)); m_debugServerPath = debugServer(m_useLldb, target); qCDebug(androidRunWorkerLog).noquote() << "Device Serial:" << m_deviceSerialNumber