feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Device support: Use value semantics for Core::Id.

Browse Source 
We had a mixed style until now (mostly using const refs). Use value
semantics everywhere for consistency and hope that the class never gets
heavier.

Change-Id: Ic9536f87b01a76252bd8643c8681b3dc9067a266
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
This commit is contained in:
Christian Kandeler
2012-04-25 09:54:31 +02:00
parent df5dab6382
commit 2994b88d90
13 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/remotelinux/linuxdeviceconfiguration.cpp
View File

@@ -84,7 +84,7 @@ LinuxDeviceConfiguration::~LinuxDeviceConfiguration()
}
LinuxDeviceConfiguration::Ptr LinuxDeviceConfiguration::create(const QString &name,
const QString &type, MachineType machineType, Origin origin, const Core::Id &id)
const QString &type, MachineType machineType, Origin origin, Core::Id id)
{
return Ptr(new LinuxDeviceConfiguration(name, type, machineType, origin, id));
}
@@ -140,7 +140,7 @@ LinuxDeviceConfiguration::LinuxDeviceConfiguration() : d(new LinuxDeviceConfigur
}
LinuxDeviceConfiguration::LinuxDeviceConfiguration(const QString &name, const QString &type,
MachineType machineType, Origin origin, const Core::Id &id)
MachineType machineType, Origin origin, Core::Id id)
: IDevice(type, origin, id), d(new LinuxDeviceConfigurationPrivate)
{
setDisplayName(name);