feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Device support: Use value semantics for Core::Id.

Browse Source 
We had a mixed style until now (mostly using const refs). Use value
semantics everywhere for consistency and hope that the class never gets
heavier.

Change-Id: Ic9536f87b01a76252bd8643c8681b3dc9067a266
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
This commit is contained in:
Christian Kandeler
2012-04-25 09:54:31 +02:00
parent df5dab6382
commit 2994b88d90
13 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/remotelinux/linuxdeviceconfiguration.h
View File

@@ -71,7 +71,7 @@ public:
static Ptr create();
static Ptr create(const QString &name, const QString &type, MachineType machineType,
Origin origin = ManuallyAdded, const Core::Id &id = Core::Id());
Origin origin = ManuallyAdded, Core::Id id = Core::Id());
QString displayType() const;
ProjectExplorer::IDeviceWidget *createWidget();
@@ -84,7 +84,7 @@ public:
protected:
LinuxDeviceConfiguration();
LinuxDeviceConfiguration(const QString &name, const QString &type, MachineType machineType,
Origin origin, const Core::Id &id);
Origin origin, Core::Id id);
LinuxDeviceConfiguration(const LinuxDeviceConfiguration &other);
QVariantMap toMap() const;