From 29dc8e740f247fd6a0204bebd892c450aec2077f Mon Sep 17 00:00:00 2001 From: David Schulz Date: Mon, 17 Feb 2020 13:40:11 +0100 Subject: [PATCH] LanguageClient: fix soft assert for uninitialized server Do not send close documents notifications to an uninitialized server Fixes: QTCREATORBUG-23598 Change-Id: Iaabd082203a91a56ebcd60f93e6a0c97048e89c1 Reviewed-by: Christian Stenger --- src/plugins/languageclient/client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/languageclient/client.cpp b/src/plugins/languageclient/client.cpp index 5d62cdfeb9a..3fc20ea3bc6 100644 --- a/src/plugins/languageclient/client.cpp +++ b/src/plugins/languageclient/client.cpp @@ -357,7 +357,7 @@ void Client::closeDocument(TextEditor::TextDocument *document) deactivateDocument(document); const DocumentUri &uri = DocumentUri::fromFilePath(document->filePath()); m_highlights[uri].clear(); - if (m_openedDocument.remove(document) != 0) { + if (m_openedDocument.remove(document) != 0 && m_state == Initialized) { DidCloseTextDocumentParams params(TextDocumentIdentifier{uri}); sendContent(DidCloseTextDocumentNotification(params)); }