feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Find: Fix an issue found by clang static analyzer

Browse Source 
Change-Id: Id556e670930b0f8e2ee47fb413c443b79a86f4d4
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
hjk
2014-05-17 21:17:15 +02:00
parent 1f45eb2c21
commit 29e4ed9f56
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/coreplugin/find/findtoolwindow.cpp
View File

@@ -32,6 +32,7 @@
#include "findplugin.h" #include "findplugin.h"
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <utils/qtcassert.h>
#include <QSettings> #include <QSettings>
#include <QStringListModel> #include <QStringListModel>
@@ -225,17 +226,18 @@ void FindToolWindow::acceptAndGetParameters(QString *term, IFindFilter **filter)
void FindToolWindow::search() void FindToolWindow::search()
{ {
QString term; QString term;
IFindFilter *filter; IFindFilter *filter = 0;
acceptAndGetParameters(&term, &filter); acceptAndGetParameters(&term, &filter);
if (filter) QTC_ASSERT(filter, return);
filter->findAll(term, m_plugin->findFlags()); filter->findAll(term, m_plugin->findFlags());
} }
void FindToolWindow::replace() void FindToolWindow::replace()
{ {
QString term; QString term;
IFindFilter *filter; IFindFilter *filter = 0;
acceptAndGetParameters(&term, &filter); acceptAndGetParameters(&term, &filter);
QTC_ASSERT(filter, return);
filter->replaceAll(term, m_plugin->findFlags()); filter->replaceAll(term, m_plugin->findFlags());
} }