DiffEditor: Make DiffEditorGuiController internal

Change-Id: I657085535b7f141c97bc3d054e9edfd236209981
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-01-30 14:46:20 +01:00
parent 956abd2803
commit 2a01738ffb
7 changed files with 20 additions and 11 deletions

View File

@@ -51,9 +51,9 @@ namespace DiffEditor {
namespace Internal { namespace Internal {
class DescriptionEditorWidget; class DescriptionEditorWidget;
class DiffEditorDocument; class DiffEditorDocument;
class DiffEditorGuiController;
} // namespace Internal } // namespace Internal
class DiffEditorGuiController;
class SideBySideDiffEditorWidget; class SideBySideDiffEditorWidget;
class UnifiedDiffEditorWidget; class UnifiedDiffEditorWidget;
@@ -104,7 +104,7 @@ private:
SideBySideDiffEditorWidget *m_sideBySideEditor; SideBySideDiffEditorWidget *m_sideBySideEditor;
UnifiedDiffEditorWidget *m_unifiedEditor; UnifiedDiffEditorWidget *m_unifiedEditor;
QWidget *m_currentEditor; QWidget *m_currentEditor;
DiffEditorGuiController *m_guiController; Internal::DiffEditorGuiController *m_guiController;
QToolBar *m_toolBar; QToolBar *m_toolBar;
QComboBox *m_entriesComboBox; QComboBox *m_entriesComboBox;
QAction *m_whitespaceButtonAction; QAction *m_whitespaceButtonAction;

View File

@@ -41,6 +41,7 @@ static const char horizontalScrollBarSynchronizationKeyC[] =
"HorizontalScrollBarSynchronization"; "HorizontalScrollBarSynchronization";
namespace DiffEditor { namespace DiffEditor {
namespace Internal {
DiffEditorGuiController::DiffEditorGuiController( DiffEditorGuiController::DiffEditorGuiController(
DiffEditorController *controller, DiffEditorController *controller,
@@ -138,4 +139,5 @@ void DiffEditorGuiController::setCurrentDiffFileIndex(int diffFileIndex)
emit currentDiffFileIndexChanged(newIndex); emit currentDiffFileIndexChanged(newIndex);
} }
} // namespace Internal
} // namespace DiffEditor } // namespace DiffEditor

View File

@@ -31,15 +31,15 @@
#ifndef DIFFEDITORGUICONTROLLER_H #ifndef DIFFEDITORGUICONTROLLER_H
#define DIFFEDITORGUICONTROLLER_H #define DIFFEDITORGUICONTROLLER_H
#include "diffeditor_global.h"
#include <QObject> #include <QObject>
namespace DiffEditor { namespace DiffEditor {
class DiffEditorController; class DiffEditorController;
class DIFFEDITOR_EXPORT DiffEditorGuiController : public QObject namespace Internal {
class DiffEditorGuiController : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
@@ -72,6 +72,7 @@ private:
int m_currentDiffFileIndex; int m_currentDiffFileIndex;
}; };
} // namespace Internal
} // namespace DiffEditor } // namespace DiffEditor
#endif // DIFFEDITORGUICONTROLLER_H #endif // DIFFEDITORGUICONTROLLER_H

View File

@@ -72,6 +72,8 @@ using namespace Utils;
namespace DiffEditor { namespace DiffEditor {
using namespace Internal;
//////////////////////// ////////////////////////
/* /*
class MultiHighlighter : public SyntaxHighlighter class MultiHighlighter : public SyntaxHighlighter

View File

@@ -46,7 +46,8 @@ QT_END_NAMESPACE
namespace DiffEditor { namespace DiffEditor {
class DiffEditorGuiController;
namespace Internal { class DiffEditorGuiController; }
class SideDiffEditorWidget; class SideDiffEditorWidget;
class ChunkData; class ChunkData;
class FileData; class FileData;
@@ -57,7 +58,7 @@ class DIFFEDITOR_EXPORT SideBySideDiffEditorWidget : public QWidget
public: public:
explicit SideBySideDiffEditorWidget(QWidget *parent = 0); explicit SideBySideDiffEditorWidget(QWidget *parent = 0);
void setDiffEditorGuiController(DiffEditorGuiController *controller); void setDiffEditorGuiController(Internal::DiffEditorGuiController *controller);
private slots: private slots:
void clear(const QString &message = QString()); void clear(const QString &message = QString());
@@ -95,7 +96,7 @@ private:
int lineNumber, int columnNumber); int lineNumber, int columnNumber);
void patch(bool revert); void patch(bool revert);
DiffEditorGuiController *m_guiController; Internal::DiffEditorGuiController *m_guiController;
DiffEditorController *m_controller; DiffEditorController *m_controller;
SideDiffEditorWidget *m_leftEditor; SideDiffEditorWidget *m_leftEditor;
SideDiffEditorWidget *m_rightEditor; SideDiffEditorWidget *m_rightEditor;

View File

@@ -70,6 +70,8 @@ using namespace TextEditor;
namespace DiffEditor { namespace DiffEditor {
using namespace Internal;
UnifiedDiffEditorWidget::UnifiedDiffEditorWidget(QWidget *parent) UnifiedDiffEditorWidget::UnifiedDiffEditorWidget(QWidget *parent)
: SelectableTextEditorWidget("DiffEditor.UnifiedDiffEditor", parent) : SelectableTextEditorWidget("DiffEditor.UnifiedDiffEditor", parent)
, m_guiController(0) , m_guiController(0)

View File

@@ -48,7 +48,8 @@ QT_END_NAMESPACE
namespace DiffEditor { namespace DiffEditor {
class DiffEditorGuiController; namespace Internal { class DiffEditorGuiController; }
class ChunkData; class ChunkData;
class FileData; class FileData;
@@ -59,7 +60,7 @@ class DIFFEDITOR_EXPORT UnifiedDiffEditorWidget
public: public:
UnifiedDiffEditorWidget(QWidget *parent = 0); UnifiedDiffEditorWidget(QWidget *parent = 0);
void setDiffEditorGuiController(DiffEditorGuiController *controller); void setDiffEditorGuiController(Internal::DiffEditorGuiController *controller);
public slots: public slots:
void setDisplaySettings(const TextEditor::DisplaySettings &ds); void setDisplaySettings(const TextEditor::DisplaySettings &ds);
@@ -113,7 +114,7 @@ private:
int chunkIndex); int chunkIndex);
void patch(bool revert); void patch(bool revert);
DiffEditorGuiController *m_guiController; Internal::DiffEditorGuiController *m_guiController;
DiffEditorController *m_controller; DiffEditorController *m_controller;
// block number, visual line number. // block number, visual line number.