feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't call FutureProgress::setKeepOnFinish(HideOnFinish)

Browse Source 
This is the default behavior so no need to set it explicitly.

Change-Id: I7248a7a3890fa7fd947b8e42fccc70383d46ca3a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2023-01-05 15:11:55 +01:00
parent 45c98836a9
commit 2a2455a6fa
3 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/clangtools/clangtoolruncontrol.cpp
View File

@@ -245,7 +245,6 @@ void ClangToolRunWorker::start()
FutureProgress *futureProgress FutureProgress *futureProgress
= ProgressManager::addTask(m_progress.future(), tr("Analyzing"), = ProgressManager::addTask(m_progress.future(), tr("Analyzing"),
toolName.toStdString().c_str()); toolName.toStdString().c_str());
futureProgress->setKeepOnFinish(FutureProgress::HideOnFinish);
connect(futureProgress, &FutureProgress::canceled, connect(futureProgress, &FutureProgress::canceled,
this, &ClangToolRunWorker::onProgressCanceled); this, &ClangToolRunWorker::onProgressCanceled);
m_progress.setProgressRange(0, m_initialQueueSize); m_progress.setProgressRange(0, m_initialQueueSize);

1
src/plugins/debugger/debuggerengine.cpp
View File

@@ -554,7 +554,6 @@ void DebuggerEnginePrivate::setupViews()
FutureProgress *fp = ProgressManager::addTask(m_progress.future(), FutureProgress *fp = ProgressManager::addTask(m_progress.future(),
Tr::tr("Launching Debugger"), "Debugger.Launcher"); Tr::tr("Launching Debugger"), "Debugger.Launcher");
connect(fp, &FutureProgress::canceled, m_engine, &DebuggerEngine::quitDebugger); connect(fp, &FutureProgress::canceled, m_engine, &DebuggerEngine::quitDebugger);
fp->setKeepOnFinish(FutureProgress::HideOnFinish);
m_progress.reportStarted(); m_progress.reportStarted();
m_inferiorPid = rp.attachPID.isValid() ? rp.attachPID : ProcessHandle(); m_inferiorPid = rp.attachPID.isValid() ? rp.attachPID : ProcessHandle();

1
src/plugins/valgrind/valgrindengine.cpp
View File

@@ -54,7 +54,6 @@ ValgrindToolRunner::ValgrindToolRunner(RunControl *runControl)
void ValgrindToolRunner::start() void ValgrindToolRunner::start()
{ {
FutureProgress *fp = ProgressManager::addTimedTask(m_progress, progressTitle(), "valgrind", 100); FutureProgress *fp = ProgressManager::addTimedTask(m_progress, progressTitle(), "valgrind", 100);
fp->setKeepOnFinish(FutureProgress::HideOnFinish);
connect(fp, &FutureProgress::canceled, connect(fp, &FutureProgress::canceled,
this, &ValgrindToolRunner::handleProgressCanceled); this, &ValgrindToolRunner::handleProgressCanceled);
connect(fp, &FutureProgress::finished, connect(fp, &FutureProgress::finished,